Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(perf-samples): Remove unused deps and files #4204

Merged
merged 3 commits into from
Oct 24, 2024

Conversation

krystofwoldrich
Copy link
Member

@krystofwoldrich krystofwoldrich commented Oct 24, 2024

💡 Motivation and Context

This dependency was unused so it was not a threat but we can also safely remove it.

Resolves:

💚 How did you test it?

ci

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  • All tests passing
  • No breaking changes

#skip-changelog

@krystofwoldrich krystofwoldrich changed the title Kw/perf-samples/cleanup chore(perf-samples): Remove unused deps and files Oct 24, 2024
Base automatically changed from kw/samples/update-gems to main October 24, 2024 09:36
Copy link
Collaborator

@lucas-zimerman lucas-zimerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

iOS (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1240.86 ms 1239.49 ms -1.37 ms
Size 2.36 MiB 3.10 MiB 753.11 KiB

Baseline results on branch: kw/samples/update-gems

Startup times

Revision Plain With Sentry Diff
c3c7a7c+dirty 1231.57 ms 1245.98 ms 14.41 ms

App size

Revision Plain With Sentry Diff
c3c7a7c+dirty 2.36 MiB 3.10 MiB 753.14 KiB

Copy link
Contributor

Android (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 387.12 ms 436.96 ms 49.84 ms
Size 7.15 MiB 8.35 MiB 1.20 MiB

Baseline results on branch: kw/samples/update-gems

Startup times

Revision Plain With Sentry Diff
c3c7a7c+dirty 358.00 ms 413.98 ms 55.98 ms

App size

Revision Plain With Sentry Diff
c3c7a7c+dirty 7.15 MiB 8.35 MiB 1.20 MiB

Copy link
Collaborator

@antonis antonis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

iOS (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1228.62 ms 1225.96 ms -2.66 ms
Size 2.92 MiB 3.66 MiB 758.42 KiB

Baseline results on branch: kw/samples/update-gems

Startup times

Revision Plain With Sentry Diff
c3c7a7c+dirty 1242.02 ms 1240.04 ms -1.98 ms

App size

Revision Plain With Sentry Diff
c3c7a7c+dirty 2.92 MiB 3.66 MiB 758.33 KiB

Copy link
Contributor

Android (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 445.98 ms 436.24 ms -9.74 ms
Size 17.74 MiB 20.08 MiB 2.34 MiB

Baseline results on branch: kw/samples/update-gems

Startup times

Revision Plain With Sentry Diff
c3c7a7c 441.46 ms 432.51 ms -8.95 ms

App size

Revision Plain With Sentry Diff
c3c7a7c 17.74 MiB 20.08 MiB 2.34 MiB

@krystofwoldrich krystofwoldrich merged commit b33f20e into main Oct 24, 2024
58 checks passed
@krystofwoldrich krystofwoldrich deleted the kw/perf-samples/cleanup branch October 24, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants