Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds breadcrumb origin field #4124

Draft
wants to merge 14 commits into
base: main
Choose a base branch
from
Draft

Adds breadcrumb origin field #4124

wants to merge 14 commits into from

Conversation

antonis
Copy link
Collaborator

@antonis antonis commented Sep 27, 2024 •
edited
Loading

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

Uses breadcrumb.origin field to prevent exception capture context from being overwritten by native scope sync

Depends on:

💡 Motivation and Context

Fixes #2146
The discussion in getsentry/sentry-capacitor#629 (comment) adds some context on the need of a new field to be used internally to solve a technical problem.

💚 How did you test it?

TODO

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  • All tests passing
  • No breaking changes

🔮 Next steps

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 8, 2024 •
edited
Loading

iOS (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1217.18 ms 1220.83 ms 3.65 ms
Size 2.36 MiB 3.10 MiB 753.14 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
700cbf4+dirty 1234.59 ms 1227.71 ms -6.88 ms
86d6d2c+dirty 1267.55 ms 1286.21 ms 18.66 ms
b95b8af+dirty 1221.39 ms 1228.52 ms 7.13 ms
6e8584e+dirty 1274.50 ms 1296.82 ms 22.32 ms
dadc233+dirty 1223.20 ms 1236.88 ms 13.68 ms
d7401ac+dirty 1252.38 ms 1275.04 ms 22.66 ms
9433f35+dirty 1246.94 ms 1271.45 ms 24.52 ms
1c65324+dirty 1235.17 ms 1235.08 ms -0.09 ms
2534337+dirty 1225.08 ms 1230.26 ms 5.17 ms
e2b64fe+dirty 1232.22 ms 1255.20 ms 22.98 ms

App size

Revision Plain With Sentry Diff
700cbf4+dirty 2.36 MiB 3.08 MiB 734.22 KiB
86d6d2c+dirty 2.36 MiB 2.82 MiB 462.82 KiB
b95b8af+dirty 2.36 MiB 3.14 MiB 793.32 KiB
6e8584e+dirty 2.36 MiB 2.88 MiB 533.17 KiB
dadc233+dirty 2.36 MiB 2.84 MiB 486.85 KiB
d7401ac+dirty 2.36 MiB 2.83 MiB 481.14 KiB
9433f35+dirty 2.36 MiB 2.85 MiB 499.80 KiB
1c65324+dirty 2.36 MiB 3.04 MiB 698.64 KiB
2534337+dirty 2.36 MiB 2.88 MiB 525.47 KiB
e2b64fe+dirty 2.36 MiB 2.85 MiB 495.80 KiB

Previous results on branch: antonis/add-breadcrumb-origin

Startup times

Revision Plain With Sentry Diff
e045c61+dirty 1236.80 ms 1238.87 ms 2.08 ms
e62bf30+dirty 1238.96 ms 1243.39 ms 4.43 ms
093a11f+dirty 1212.48 ms 1229.21 ms 16.73 ms

App size

Revision Plain With Sentry Diff
e045c61+dirty 2.36 MiB 3.10 MiB 753.19 KiB
e62bf30+dirty 2.36 MiB 3.15 MiB 802.94 KiB
093a11f+dirty 2.36 MiB 3.10 MiB 752.44 KiB

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 8, 2024 •
edited
Loading

iOS (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1237.70 ms 1239.14 ms 1.44 ms
Size 2.92 MiB 3.66 MiB 758.41 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
700cbf4+dirty 1233.96 ms 1228.27 ms -5.69 ms
86d6d2c+dirty 1291.62 ms 1296.80 ms 5.18 ms
b95b8af+dirty 1235.60 ms 1242.06 ms 6.46 ms
6e8584e+dirty 1271.71 ms 1281.26 ms 9.55 ms
dadc233+dirty 1266.52 ms 1282.55 ms 16.03 ms
d7401ac+dirty 1288.10 ms 1289.54 ms 1.44 ms
9433f35+dirty 1232.24 ms 1232.74 ms 0.50 ms
1c65324+dirty 1239.71 ms 1239.86 ms 0.15 ms
2534337+dirty 1220.87 ms 1221.47 ms 0.60 ms
e2b64fe+dirty 1285.78 ms 1297.56 ms 11.78 ms

App size

Revision Plain With Sentry Diff
700cbf4+dirty 2.92 MiB 3.64 MiB 740.57 KiB
86d6d2c+dirty 2.92 MiB 3.37 MiB 464.31 KiB
b95b8af+dirty 2.92 MiB 3.69 MiB 794.16 KiB
6e8584e+dirty 2.92 MiB 3.44 MiB 536.52 KiB
dadc233+dirty 2.92 MiB 3.40 MiB 492.53 KiB
d7401ac+dirty 2.92 MiB 3.40 MiB 488.06 KiB
9433f35+dirty 2.92 MiB 3.41 MiB 503.55 KiB
1c65324+dirty 2.92 MiB 3.61 MiB 705.56 KiB
2534337+dirty 2.92 MiB 3.43 MiB 529.76 KiB
e2b64fe+dirty 2.92 MiB 3.41 MiB 499.97 KiB

Previous results on branch: antonis/add-breadcrumb-origin

Startup times

Revision Plain With Sentry Diff
e045c61+dirty 1225.21 ms 1230.33 ms 5.12 ms
e62bf30+dirty 1239.42 ms 1242.14 ms 2.73 ms
093a11f+dirty 1238.33 ms 1237.33 ms -1.01 ms

App size

Revision Plain With Sentry Diff
e045c61+dirty 2.92 MiB 3.66 MiB 758.40 KiB
e62bf30+dirty 2.92 MiB 3.71 MiB 808.09 KiB
093a11f+dirty 2.92 MiB 3.66 MiB 757.73 KiB

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 10, 2024 •
edited
Loading

Android (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 478.18 ms 564.25 ms 86.07 ms
Size 7.15 MiB 8.35 MiB 1.20 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
5a22220+dirty 384.61 ms 419.06 ms 34.45 ms
76d1baf+dirty 339.02 ms 408.65 ms 69.63 ms
700cbf4+dirty 411.71 ms 485.52 ms 73.81 ms
27ef4ee+dirty 296.71 ms 351.00 ms 54.29 ms
b95b8af+dirty 392.94 ms 428.00 ms 35.06 ms
52a8031+dirty 330.72 ms 358.76 ms 28.03 ms
34aba08+dirty 331.79 ms 376.69 ms 44.91 ms
a989877+dirty 383.04 ms 400.92 ms 17.88 ms
62a750b+dirty 370.78 ms 376.73 ms 5.96 ms
22e31b6+dirty 295.75 ms 346.73 ms 50.98 ms

App size

Revision Plain With Sentry Diff
5a22220+dirty 7.15 MiB 8.21 MiB 1.06 MiB
76d1baf+dirty 7.15 MiB 8.09 MiB 964.41 KiB
700cbf4+dirty 7.15 MiB 8.34 MiB 1.19 MiB
27ef4ee+dirty 7.15 MiB 8.08 MiB 959.49 KiB
b95b8af+dirty 7.15 MiB 8.38 MiB 1.23 MiB
52a8031+dirty 7.15 MiB 8.09 MiB 965.95 KiB
34aba08+dirty 7.15 MiB 8.07 MiB 946.13 KiB
a989877+dirty 7.15 MiB 8.35 MiB 1.20 MiB
62a750b+dirty 7.15 MiB 8.21 MiB 1.06 MiB
22e31b6+dirty 7.15 MiB 8.10 MiB 981.29 KiB

Previous results on branch: antonis/add-breadcrumb-origin

Startup times

Revision Plain With Sentry Diff
e045c61+dirty 434.98 ms 463.36 ms 28.38 ms
093a11f+dirty 415.54 ms 461.00 ms 45.46 ms
e62bf30+dirty 369.36 ms 405.27 ms 35.92 ms

App size

Revision Plain With Sentry Diff
e045c61+dirty 7.15 MiB 8.35 MiB 1.20 MiB
093a11f+dirty 7.15 MiB 8.35 MiB 1.20 MiB
e62bf30+dirty 7.15 MiB 8.39 MiB 1.24 MiB

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 11, 2024 •
edited
Loading

Android (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 488.43 ms 500.04 ms 11.62 ms
Size 17.74 MiB 20.07 MiB 2.34 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
5a22220 412.38 ms 447.35 ms 34.97 ms
76d1baf+dirty 335.72 ms 355.52 ms 19.80 ms
baa882f 354.93 ms 356.18 ms 1.25 ms
0ebca77 414.93 ms 444.49 ms 29.56 ms
52a8031+dirty 311.55 ms 321.37 ms 9.82 ms
ad6c299 375.94 ms 382.02 ms 6.08 ms
148f924 492.65 ms 500.28 ms 7.63 ms
1c65324 426.37 ms 460.36 ms 33.99 ms
abb7058 370.27 ms 389.58 ms 19.31 ms
5446992 403.40 ms 426.70 ms 23.30 ms

App size

Revision Plain With Sentry Diff
5a22220 17.73 MiB 19.93 MiB 2.20 MiB
76d1baf+dirty 17.73 MiB 20.04 MiB 2.31 MiB
baa882f 17.73 MiB 20.06 MiB 2.33 MiB
0ebca77 17.73 MiB 19.95 MiB 2.21 MiB
52a8031+dirty 17.73 MiB 20.04 MiB 2.31 MiB
ad6c299 17.73 MiB 19.75 MiB 2.02 MiB
148f924 17.73 MiB 19.94 MiB 2.21 MiB
1c65324 17.73 MiB 19.95 MiB 2.21 MiB
abb7058 17.73 MiB 19.83 MiB 2.10 MiB
5446992 17.73 MiB 19.85 MiB 2.12 MiB

Previous results on branch: antonis/add-breadcrumb-origin

Startup times

Revision Plain With Sentry Diff
093a11f 471.67 ms 487.81 ms 16.15 ms
e045c61 395.70 ms 386.29 ms -9.41 ms
e62bf30 481.92 ms 471.48 ms -10.44 ms

App size

Revision Plain With Sentry Diff
093a11f 17.74 MiB 20.07 MiB 2.34 MiB
e045c61 17.74 MiB 20.07 MiB 2.34 MiB
e62bf30 17.73 MiB 20.11 MiB 2.38 MiB

@antonis
Merge branch 'main' into antonis/add-breadcrumb-origin
0e43c5d 
# Conflicts:
#	CHANGELOG.md
@antonis
Merge branch 'main' into antonis/add-breadcrumb-origin
8832cf9 
# Conflicts:
#	packages/core/android/src/main/java/io/sentry/react/RNSentryBreadcrumb.java
@antonis antonis mentioned this pull request Oct 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krystofwoldrich krystofwoldrich Awaiting requested review from krystofwoldrich krystofwoldrich will be requested when the pull request is marked ready for review krystofwoldrich is a code owner

@lucas-zimerman lucas-zimerman Awaiting requested review from lucas-zimerman lucas-zimerman will be requested when the pull request is marked ready for review lucas-zimerman is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Exception capture context is overwritten by native scope sync
1 participant
@antonis