Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update JavaScript SDK to v7.99.0 #3574

Merged
merged 6 commits into from
Feb 5, 2024
Merged

Conversation

krystofwoldrich
Copy link
Member

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

This PR bumps JS SDK to 7.99.0 and disables lint deprecation warnings TMP.

There are over 150 deprecations in the SDK code and over 250 in the test. I will create a follow-up PR which fixes the deprecations to make it easier to review.

💚 How did you test it?

ci

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  • All tests passing
  • No breaking changes

🔮 Next steps

Copy link
Contributor

github-actions bot commented Feb 1, 2024

Android (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 352.06 ms 396.35 ms 44.28 ms
Size 7.15 MiB 8.18 MiB 1.03 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
5446992+dirty 371.61 ms 390.00 ms 18.39 ms
728164b+dirty 335.93 ms 342.94 ms 7.01 ms
1d86dd6+dirty 335.76 ms 371.22 ms 35.46 ms
e73f4ed+dirty 262.98 ms 311.02 ms 48.04 ms
ad6c299+dirty 336.47 ms 362.89 ms 26.42 ms
9433f35+dirty 265.50 ms 336.08 ms 70.58 ms
457e29f+dirty 591.49 ms 612.96 ms 21.47 ms
86d6d2c+dirty 267.21 ms 325.24 ms 58.04 ms
12427f4+dirty 379.48 ms 400.92 ms 21.44 ms
abb7058+dirty 320.78 ms 324.08 ms 3.30 ms

App size

Revision Plain With Sentry Diff
5446992+dirty 7.15 MiB 8.12 MiB 999.45 KiB
728164b+dirty 7.15 MiB 8.12 MiB 997.71 KiB
1d86dd6+dirty 7.15 MiB 8.13 MiB 1002.18 KiB
e73f4ed+dirty 7.15 MiB 8.09 MiB 965.94 KiB
ad6c299+dirty 7.15 MiB 8.04 MiB 912.17 KiB
9433f35+dirty 7.15 MiB 8.08 MiB 959.34 KiB
457e29f+dirty 7.15 MiB 8.10 MiB 981.29 KiB
86d6d2c+dirty 7.15 MiB 8.09 MiB 962.69 KiB
12427f4+dirty 7.15 MiB 8.12 MiB 997.78 KiB
abb7058+dirty 7.15 MiB 8.10 MiB 980.40 KiB

Copy link
Contributor

github-actions bot commented Feb 1, 2024

iOS (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1219.83 ms 1227.23 ms 7.40 ms
Size 2.36 MiB 2.90 MiB 552.95 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
9433f35+dirty 1246.94 ms 1271.45 ms 24.52 ms
9c48b2c+dirty 1246.96 ms 1255.73 ms 8.77 ms
1d86dd6+dirty 1249.71 ms 1279.16 ms 29.45 ms
d361d38+dirty 1246.04 ms 1267.12 ms 21.08 ms
12427f4+dirty 1267.15 ms 1271.30 ms 4.15 ms
6e8584e+dirty 1274.50 ms 1296.82 ms 22.32 ms
3ffcddd+dirty 1244.47 ms 1264.14 ms 19.67 ms
22e31b6+dirty 1253.62 ms 1265.96 ms 12.34 ms
0677344+dirty 1276.70 ms 1300.07 ms 23.37 ms
3853f43+dirty 1221.82 ms 1242.64 ms 20.82 ms

App size

Revision Plain With Sentry Diff
9433f35+dirty 2.36 MiB 2.85 MiB 499.80 KiB
9c48b2c+dirty 2.36 MiB 2.85 MiB 495.77 KiB
1d86dd6+dirty 2.36 MiB 2.89 MiB 535.43 KiB
d361d38+dirty 2.36 MiB 2.85 MiB 499.84 KiB
12427f4+dirty 2.36 MiB 2.88 MiB 530.38 KiB
6e8584e+dirty 2.36 MiB 2.88 MiB 533.17 KiB
3ffcddd+dirty 2.36 MiB 2.84 MiB 489.60 KiB
22e31b6+dirty 2.36 MiB 2.87 MiB 520.67 KiB
0677344+dirty 2.36 MiB 2.85 MiB 496.81 KiB
3853f43+dirty 2.36 MiB 2.85 MiB 499.81 KiB

Copy link
Collaborator

@lucas-zimerman lucas-zimerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

github-actions bot commented Feb 5, 2024

Android (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 388.11 ms 412.92 ms 24.81 ms
Size 17.73 MiB 19.90 MiB 2.17 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
728164b 414.34 ms 449.22 ms 34.88 ms
34aba08 328.10 ms 342.84 ms 14.74 ms
b1e8712 462.11 ms 465.71 ms 3.60 ms
e73f4ed+dirty 332.96 ms 354.33 ms 21.37 ms
9433f35 347.64 ms 356.22 ms 8.58 ms
457e29f 398.10 ms 421.39 ms 23.29 ms
86d6d2c+dirty 332.90 ms 352.45 ms 19.55 ms
3853f43 329.68 ms 346.32 ms 16.64 ms
2534337 394.15 ms 415.12 ms 20.97 ms
3ffcddd 302.92 ms 315.80 ms 12.88 ms

App size

Revision Plain With Sentry Diff
728164b 17.73 MiB 19.85 MiB 2.12 MiB
34aba08 17.73 MiB 19.80 MiB 2.07 MiB
b1e8712 17.73 MiB 19.75 MiB 2.02 MiB
e73f4ed+dirty 17.73 MiB 20.04 MiB 2.31 MiB
9433f35 17.73 MiB 19.81 MiB 2.08 MiB
457e29f 17.73 MiB 19.84 MiB 2.10 MiB
86d6d2c+dirty 17.73 MiB 20.04 MiB 2.31 MiB
3853f43 17.73 MiB 19.81 MiB 2.08 MiB
2534337 17.73 MiB 19.84 MiB 2.11 MiB
3ffcddd 17.73 MiB 19.75 MiB 2.02 MiB

@krystofwoldrich krystofwoldrich merged commit 31fcca2 into main Feb 5, 2024
48 of 50 checks passed
@krystofwoldrich krystofwoldrich deleted the kw-fix-js branch February 5, 2024 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants