Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(web): Fix JSX build errors when using Webpack #3428

Merged
merged 9 commits into from
Nov 30, 2023
Merged

fix(web): Fix JSX build errors when using Webpack #3428

merged 9 commits into from
Nov 30, 2023

Conversation

krystofwoldrich
Copy link
Member

📢 Type of change

  • Bugfix

📜 Description

This PR does not add official react-native-web support.

Only removes current build errors.

💡 Motivation and Context

💚 How did you test it?

expo sample app

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  • All tests passing
  • [ x] No breaking changes

🔮 Next steps

  • add web build ci job

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 28, 2023 •
edited
Loading

Android (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 441.92 ms 483.04 ms 41.12 ms
Size 17.73 MiB 19.84 MiB 2.11 MiB

@krystofwoldrich krystofwoldrich mentioned this pull request Nov 28, 2023
Merged
6 tasks
@github-actions GitHub Actions
Copy link
Contributor

iOS (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1247.92 ms 1260.20 ms 12.28 ms
Size 2.92 MiB 3.43 MiB 524.93 KiB

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 28, 2023 •
edited
Loading

Android (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 356.15 ms 386.82 ms 30.67 ms
Size 7.15 MiB 8.11 MiB 987.05 KiB

lucas-zimerman
lucas-zimerman approved these changes Nov 28, 2023
View reviewed changes
Copy link
Collaborator

@lucas-zimerman lucas-zimerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Base automatically changed from kw-expo-sample to expo November 29, 2023 16:08
@krystofwoldrich krystofwoldrich merged commit 5b207d9 into expo Nov 30, 2023
45 of 47 checks passed
@krystofwoldrich krystofwoldrich deleted the kw-fix-webpack-build branch November 30, 2023 13:48
@github-actions GitHub Actions
Copy link
Contributor

Fails
🚫 Please consider adding a changelog entry for the next release.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

## Unreleased

- Fix JSX build errors when using Webpack ([#3428](https://github.com/getsentry/sentry-react-native/pull/3428))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description.

Generated by 🚫 dangerJS against 22f1d50

@github-actions GitHub Actions
Copy link
Contributor

iOS (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1203.30 ms 1204.77 ms 1.47 ms
Size 2.36 MiB 2.87 MiB 521.05 KiB

@krystofwoldrich krystofwoldrich mentioned this pull request Nov 30, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucas-zimerman lucas-zimerman lucas-zimerman approved these changes

@lforst lforst Awaiting requested review from lforst

@Lms24 Lms24 Awaiting requested review from Lms24

@AbhiPrasad AbhiPrasad Awaiting requested review from AbhiPrasad

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@krystofwoldrich @lucas-zimerman