Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ci): Add iOS Codegen Job #2840

Merged
merged 4 commits into from
Feb 23, 2023
Merged

feat(ci): Add iOS Codegen Job #2840

merged 4 commits into from
Feb 23, 2023

Conversation

krystofwoldrich
Copy link
Member

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

Add job codegen for ios.

💡 Motivation and Context

unblocked by: https://github.com/facebook/react-native/releases/tag/v0.70.4

💚 How did you test it?

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  • All tests passing
  • No breaking changes

🔮 Next steps

#skip-changelog

Base automatically changed from 5.0.0 to main February 21, 2023 12:15
@github-actions
Copy link
Contributor

github-actions bot commented Feb 21, 2023

Android (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 368.81 ms 379.94 ms 11.13 ms
Size 17.73 MiB 20.04 MiB 2.31 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
86d6d2c+dirty 332.90 ms 352.45 ms 19.55 ms
d197b5c+dirty 338.94 ms 354.87 ms 15.93 ms

App size

Revision Plain With Sentry Diff
86d6d2c+dirty 17.73 MiB 20.04 MiB 2.31 MiB
d197b5c+dirty 17.73 MiB 20.04 MiB 2.31 MiB

Previous results on branch: kw-ci-ios-codegen

Startup times

Revision Plain With Sentry Diff
a660c4f+dirty 334.61 ms 348.73 ms 14.12 ms

App size

Revision Plain With Sentry Diff
a660c4f+dirty 17.73 MiB 20.04 MiB 2.31 MiB

@github-actions
Copy link
Contributor

github-actions bot commented Feb 21, 2023

iOS (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1247.42 ms 1261.18 ms 13.76 ms
Size 2.36 MiB 2.82 MiB 462.83 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
86d6d2c+dirty 1267.55 ms 1286.21 ms 18.66 ms
d197b5c+dirty 1217.61 ms 1242.66 ms 25.05 ms

App size

Revision Plain With Sentry Diff
86d6d2c+dirty 2.36 MiB 2.82 MiB 462.82 KiB
d197b5c+dirty 2.36 MiB 2.82 MiB 462.86 KiB

Previous results on branch: kw-ci-ios-codegen

Startup times

Revision Plain With Sentry Diff
a660c4f+dirty 1242.43 ms 1249.14 ms 6.71 ms

App size

Revision Plain With Sentry Diff
a660c4f+dirty 2.36 MiB 2.82 MiB 462.84 KiB

@github-actions
Copy link
Contributor

github-actions bot commented Feb 21, 2023

iOS (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1259.30 ms 1260.62 ms 1.32 ms
Size 2.92 MiB 3.37 MiB 464.31 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
86d6d2c+dirty 1291.62 ms 1296.80 ms 5.18 ms
d197b5c+dirty 1234.80 ms 1249.20 ms 14.40 ms

App size

Revision Plain With Sentry Diff
86d6d2c+dirty 2.92 MiB 3.37 MiB 464.31 KiB
d197b5c+dirty 2.92 MiB 3.37 MiB 464.41 KiB

Previous results on branch: kw-ci-ios-codegen

Startup times

Revision Plain With Sentry Diff
a660c4f+dirty 1257.82 ms 1268.60 ms 10.78 ms

App size

Revision Plain With Sentry Diff
a660c4f+dirty 2.92 MiB 3.37 MiB 464.32 KiB

@github-actions
Copy link
Contributor

github-actions bot commented Feb 21, 2023

Android (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 255.96 ms 306.47 ms 50.51 ms
Size 7.15 MiB 8.09 MiB 962.69 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
86d6d2c+dirty 267.21 ms 325.24 ms 58.04 ms
d197b5c+dirty 258.75 ms 313.61 ms 54.86 ms

App size

Revision Plain With Sentry Diff
86d6d2c+dirty 7.15 MiB 8.09 MiB 962.69 KiB
d197b5c+dirty 7.15 MiB 8.09 MiB 962.72 KiB

Previous results on branch: kw-ci-ios-codegen

Startup times

Revision Plain With Sentry Diff
a660c4f+dirty 322.40 ms 358.36 ms 35.96 ms

App size

Revision Plain With Sentry Diff
a660c4f+dirty 7.15 MiB 8.09 MiB 962.72 KiB

Copy link
Member

@kahest kahest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📱 🚀

.github/workflows/codegen.yml Outdated Show resolved Hide resolved
@krystofwoldrich krystofwoldrich changed the title Add CI iOS Codegen Job feat(ci): Add iOS Codegen Job Feb 23, 2023
@krystofwoldrich krystofwoldrich merged commit 2ccadb5 into main Feb 23, 2023
@krystofwoldrich krystofwoldrich deleted the kw-ci-ios-codegen branch February 23, 2023 12:50
@github-actions
Copy link
Contributor

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 0ce3703

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants