Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not work with Jenkins #389

Closed
2 of 5 tasks
firatakandere opened this issue Apr 9, 2018 · 2 comments
Closed
2 of 5 tasks

Does not work with Jenkins #389

firatakandere opened this issue Apr 9, 2018 · 2 comments
Assignees

Comments

@firatakandere
Copy link

firatakandere commented Apr 9, 2018

OS:

  • Windows
  • MacOS
  • Linux

Platform:

  • iOS
  • Android

Output of node -v && npm -v && npm ls --prod --depth=0 (from Jenkins)

+ node -v
v9.8.0
+ npm -v
5.6.0
+ npm ls --prod --depth=0
/Users/[username]/.jenkins/workspace/test

I have following issue:

I have Jenkins installed on my old Mac to automate the building process. I can successfully compile the project through its command line. But when I run the the compilation through Jenkins, I get the error on Build Phase:

Actual result:

❌  error: Can't find '/Users/[username]/.jenkins/workspace/[project path]/node_modules/@sentry/cli/sentry-cli' binary to build React Native bundle

PS:

  • The file is actually there, if I create a Jenkins task that calls this file, the Jenkins can call it, and sentry-cli returns the help text. Therefore I don't think there's a permission issue between Jenkins and sentry-cli file.
@HazAT HazAT self-assigned this Apr 16, 2018
@HazAT
Copy link
Member

HazAT commented Apr 16, 2018

Hey, can you test a simple Jenkins job that does
npm install @sentry/cli
and then calls node node_modules/.bin/sentry-cli to check if that works.
It seems very odd that it does not work.

@firatakandere
Copy link
Author

Sorry that I forgot the close the issue. The real reason was that the path included white spaces and one of the tools (probably xcode) does not escape it by default.

facebook-github-bot pushed a commit to facebook/react-native that referenced this issue Oct 25, 2018
Summary:
Fix build errors when path to $NODE_BINARY contains spaces:

error: Can't find '/Path/With Spaces/To/node' binary to build React Native bundle

Why would $NODE_BINARY contain spaces? In my case, I am using sentry-cli which wraps the NODE_BINARY in it's own executable. The local path to the project, and thus the $NODE_BINARY, contains a space on my GoCD build agent.

'/Users/go/Library/Application Support/Go Agent/pipelines/my-ios-app/node_modules/sentry/cli/sentry-cli

See getsentry/sentry-react-native#484 getsentry/sentry-react-native#389
Pull Request resolved: #21383

Differential Revision: D10851141

Pulled By: yungsters

fbshipit-source-id: f46853ac8b57957864e0d1a76b8513403223fccb
kelset pushed a commit to facebook/react-native that referenced this issue Nov 9, 2018
Summary:
Fix build errors when path to $NODE_BINARY contains spaces:

error: Can't find '/Path/With Spaces/To/node' binary to build React Native bundle

Why would $NODE_BINARY contain spaces? In my case, I am using sentry-cli which wraps the NODE_BINARY in it's own executable. The local path to the project, and thus the $NODE_BINARY, contains a space on my GoCD build agent.

'/Users/go/Library/Application Support/Go Agent/pipelines/my-ios-app/node_modules/sentry/cli/sentry-cli

See getsentry/sentry-react-native#484 getsentry/sentry-react-native#389
Pull Request resolved: #21383

Differential Revision: D10851141

Pulled By: yungsters

fbshipit-source-id: f46853ac8b57957864e0d1a76b8513403223fccb
t-nanava pushed a commit to microsoft/react-native-macos that referenced this issue Jun 17, 2019
Summary:
Fix build errors when path to $NODE_BINARY contains spaces:

error: Can't find '/Path/With Spaces/To/node' binary to build React Native bundle

Why would $NODE_BINARY contain spaces? In my case, I am using sentry-cli which wraps the NODE_BINARY in it's own executable. The local path to the project, and thus the $NODE_BINARY, contains a space on my GoCD build agent.

'/Users/go/Library/Application Support/Go Agent/pipelines/my-ios-app/node_modules/sentry/cli/sentry-cli

See getsentry/sentry-react-native#484 getsentry/sentry-react-native#389
Pull Request resolved: facebook#21383

Differential Revision: D10851141

Pulled By: yungsters

fbshipit-source-id: f46853ac8b57957864e0d1a76b8513403223fccb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants