Use cached methods SentryDebugImageProvider of the Cocoa SDK (#4194)

* Updates sentry-cocoa to 8.39.0-beta.1 * Replaces getDebugImagesForAddresses:isCrash: with getDebugImagesForImageAddressesFromCache * Updates changelog * Updates sentry-cocoa to 8.39.0 * Remove private function declaration
getsentry · Nov 7, 2024 · cdf2f33 · cdf2f33
1 parent f9c38c7
commit cdf2f33
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 13 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -34,6 +34,7 @@
 
 - Skips ignoring require cycle logs for RN 0.70 or newer ([#4214](https://github.com/getsentry/sentry-react-native/pull/4214))
 - Enhanced accuracy of time-to-display spans. ([#4189](https://github.com/getsentry/sentry-react-native/pull/4189))
+- Speed up getBinaryImages for finishing transactions and capturing events ([#4194](https://github.com/getsentry/sentry-react-native/pull/4194))
 
 ### Features
 

diff --git a/packages/core/RNSentryCocoaTester/RNSentryCocoaTesterTests/RNSentryTests.mm b/packages/core/RNSentryCocoaTester/RNSentryCocoaTesterTests/RNSentryTests.mm
@@ -1,6 +1,7 @@
 #import "RNSentryTests.h"
 #import <OCMock/OCMock.h>
 #import <RNSentry/RNSentry.h>
+#import <Sentry/SentryDebugImageProvider+HybridSDKs.h>
 #import <UIKit/UIKit.h>
 #import <XCTest/XCTest.h>
 
@@ -327,9 +328,9 @@ - (void)prepareNativeFrameMocksWithLocalSymbolication:(BOOL)debug
     OCMStub([sentryDebugImageMock serialize]).andReturn(serializedDebugImage);
 
     id sentryDebugImageProviderMock = OCMClassMock([SentryDebugImageProvider class]);
-    OCMStub([sentryDebugImageProviderMock
-                getDebugImagesForAddresses:[NSSet setWithObject:@"0x000000000001b669"]
-                                   isCrash:false])
+    OCMStub(
+        [sentryDebugImageProviderMock
+            getDebugImagesForImageAddressesFromCache:[NSSet setWithObject:@"0x000000000001b669"]])
         .andReturn(@[ sentryDebugImageMock ]);
 
     OCMStub([sentryDependencyContainerMock debugImageProvider])

diff --git a/packages/core/ios/RNSentry.h b/packages/core/ios/RNSentry.h
@@ -13,13 +13,6 @@
 
 typedef int (*SymbolicateCallbackType)(const void *, Dl_info *);
 
-@interface
-SentryDebugImageProvider ()
-- (NSArray<SentryDebugMeta *> *_Nonnull)getDebugImagesForAddresses:
-                                            (NSSet<NSString *> *_Nonnull)addresses
-                                                           isCrash:(BOOL)isCrash;
-@end
-
 @interface
 SentrySDK (Private)
 @property (nonatomic, nullable, readonly, class) SentryOptions *options;

diff --git a/packages/core/ios/RNSentry.mm b/packages/core/ios/RNSentry.mm
@@ -21,6 +21,7 @@
 #import <Sentry/PrivateSentrySDKOnly.h>
 #import <Sentry/SentryAppStartMeasurement.h>
 #import <Sentry/SentryBinaryImageCache.h>
+#import <Sentry/SentryDebugImageProvider+HybridSDKs.h>
 #import <Sentry/SentryDependencyContainer.h>
 #import <Sentry/SentryFormatter.h>
 #import <Sentry/SentryOptions+HybridSDKs.h>
@@ -368,9 +369,9 @@ - (NSDictionary *)fetchNativeStackFramesBy:(NSArray<NSNumber *> *)instructionsAd
         NSMutableArray<NSDictionary<NSString *, id> *> *_Nonnull serializedDebugMetaImages =
             [[NSMutableArray alloc] init];
 
-        NSArray<SentryDebugMeta *> *debugMetaImages = [[[SentryDependencyContainer sharedInstance]
-            debugImageProvider] getDebugImagesForAddresses:imagesAddrToRetrieveDebugMetaImages
-                                                   isCrash:false];
+        NSArray<SentryDebugMeta *> *debugMetaImages =
+            [[[SentryDependencyContainer sharedInstance] debugImageProvider]
+                getDebugImagesForImageAddressesFromCache:imagesAddrToRetrieveDebugMetaImages];
 
         for (SentryDebugMeta *debugImage in debugMetaImages) {
             [serializedDebugMetaImages addObject:[debugImage serialize]];