Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop Using Hub in HttpTransport #3232

Closed
szokeasaurusrex opened this issue Jul 2, 2024 · 0 comments · Fixed by #3247
Closed

Stop Using Hub in HttpTransport #3232

szokeasaurusrex opened this issue Jul 2, 2024 · 0 comments · Fixed by #3247
Assignees
@szokeasaurusrex

Comments

@szokeasaurusrex
Copy link
Member

We are still using the deprecated Hub in HttpTransport:

sentry-python/sentry_sdk/transport.py

Lines 221 to 223 in 407f651

from sentry_sdk import Hub
self.hub_cls = Hub

sentry-python/sentry_sdk/transport.py

Lines 551 to 555 in 407f651

hub = self.hub_cls.current
def send_envelope_wrapper():
# type: () -> None
with hub:

We should stop using the Hub here, as it is deprecated
@szokeasaurusrex szokeasaurusrex self-assigned this Jul 4, 2024
szokeasaurusrex added a commit that referenced this issue Jul 4, 2024
@szokeasaurusrex
ref(transport): Stop using Hub in HttpTransport
dfd0d2a 
Also, add deprecation warnings for `HttpTransport.hub_cls`.

Fixes #3232
@szokeasaurusrex szokeasaurusrex mentioned this issue Jul 4, 2024
Merged
szokeasaurusrex added a commit that referenced this issue Jul 4, 2024
@szokeasaurusrex
ref(transport): Stop using Hub in HttpTransport
c05afaa 
Also, add deprecation warnings for `HttpTransport.hub_cls`.

Fixes #3232
szokeasaurusrex added a commit that referenced this issue Jul 4, 2024
@szokeasaurusrex
ref(transport): Stop using Hub in HttpTransport
05d2087 
Also, add deprecation warnings for `HttpTransport.hub_cls`.

Fixes #3232
arjennienhuis pushed a commit to arjennienhuis/sentry-python that referenced this issue Sep 30, 2024
@szokeasaurusrex @arjenzorgdoc
ref(transport): Stop using Hub in HttpTransport (getsentry#3247)
e88c5db 
Also, add deprecation warnings for `HttpTransport.hub_cls`.

Fixes getsentry#3232
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@szokeasaurusrex szokeasaurusrex

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ref(transport): Stop using Hub in HttpTransport getsentry/sentry-python
1 participant
@szokeasaurusrex