Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the $errcontext argument of the ErrorHandler::handleError() method nullable #917

Merged
merged 1 commit into from
Nov 2, 2019
Merged

Make the $errcontext argument of the ErrorHandler::handleError() method nullable #917

merged 1 commit into from
Nov 2, 2019

Conversation

ste93cry
Copy link
Contributor

@ste93cry ste93cry commented Nov 2, 2019

Q A
Branch? 2.2
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
License MIT

This closes #912 by making the $errcontext argument of the ErrorHandler::handleError() nullable. Even though the PHP documentation don't mention this, actually looking at the PHP source code up to 8.0 the argument can receive a null value

@ste93cry ste93cry added this to the 2.2 milestone Nov 2, 2019
@ste93cry ste93cry requested a review from Jean85 November 2, 2019 18:28
@ste93cry ste93cry merged commit b5e180b into getsentry:master Nov 2, 2019
@ste93cry ste93cry deleted the fix/errcontext-error-handler-arg-nullable branch November 2, 2019 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jean85 Jean85 Jean85 approved these changes

Assignees
No one assigned
Labels
Type: Bug
Projects
None yet
Milestone
2.2
Development

Successfully merging this pull request may close these issues.

Make $errcontext nullable
2 participants
@ste93cry @Jean85