Add a config option to allow overriding Spotlight url #1659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows a different host or port to be used - for example, a different docker container on the network which has node installed, or if port 8969 is already in use for something else.
This appears to be the currenet practice for similar methods in Options, like the one above in the baseline.
cleptric
approved these changes
Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR follows issue #1658 and adds a "spotlight_url" config option, to allow overriding the sidecar url used by Spotlight.
I think I've done everything needed - I've run all the tests I found in the composer scripts except Psalm (I had extension issues that wouldn't let it run...), and tried to follow the existing patterns I could see. I copied these changes into my project, and it worked as I expected it to!