Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Expose a method to clear the module cache #216

Merged
merged 2 commits into from
Apr 3, 2020
Merged

Conversation

Swatinem
Copy link
Member

@Swatinem Swatinem commented Apr 2, 2020

fixes #213

Also make sentry_options_get_http_proxy const-correct, fixes #214

fixes #213

Also make `sentry_options_get_http_proxy` const-correct, fixes #214
@Swatinem Swatinem requested a review from jan-auer April 2, 2020 10:11
Copy link
Contributor

@flub flub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

going by the comment being removed it seems the default timeout is 1h. so i guess that still stops it from being completely stuck

@Swatinem
Copy link
Member Author

Swatinem commented Apr 3, 2020

going by the comment being removed it seems the default timeout is 1h. so i guess that still stops it from being completely stuck

yes. Originally, I added the timeout and the comment because I messed up the start script, which did basically nothing for an hour before being timed out. Now that the script at least does what it should, its rather a matter of how quick the CI machine running the job actually is. We have simulator starts in a minute, or 6 minutes, its very random. :-(

@Swatinem Swatinem merged commit bf375b0 into master Apr 3, 2020
@Swatinem Swatinem deleted the fix/modulecache branch April 3, 2020 08:37
@@ -538,7 +538,8 @@ SENTRY_API void sentry_options_set_http_proxy(
/*
* returns the configured http proxy
*/
SENTRY_API const char *sentry_options_get_http_proxy(sentry_options_t *opts);
SENTRY_API const char *sentry_options_get_http_proxy(
const sentry_options_t *opts);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you make such bug fixes in separate PRs? By looking at the git history, it gets easier to see changes and when writing the changelog we don't miss things (especially when someone else writes it).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. I was just mashing together a few oneliners in this PR to avoid the overhead ;-) But yes, that overhead actually serves a very good purpose.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants