Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: crashpad support for C++17 compilers. #1110

Merged
merged 7 commits into from
Jan 10, 2025

Conversation

supervacuus
Copy link
Collaborator

Fixes #1041 by introducing a fork for the transitive mini_chromium dependency. For details: getsentry/crashpad#116.

@supervacuus supervacuus force-pushed the feat/crashpad_cxx17_support branch from 092d889 to 4759af7 Compare December 29, 2024 16:38
Copy link

github-actions bot commented Dec 29, 2024

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 739e168

Copy link

codecov bot commented Dec 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.52%. Comparing base (b24b30c) to head (739e168).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1110      +/-   ##
==========================================
- Coverage   82.58%   82.52%   -0.07%     
==========================================
  Files          53       53              
  Lines        7896     7896              
  Branches     1234     1234              
==========================================
- Hits         6521     6516       -5     
- Misses       1265     1268       +3     
- Partials      110      112       +2     

Copy link
Member

@JoshuaMoelans JoshuaMoelans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@supervacuus
Copy link
Collaborator Author

supervacuus commented Jan 2, 2025

LGTM

Great! Happy New Year, @JoshuaMoelans.

I want to review the changes needed in the forks line-by-line with you before we merge anything. A considerable amount of C++17 and 20 specifics require changing, and I want to ensure these are clear. We also must find a getsentry home for the mini_chromium fork first (since this is currently hosted on my Github).

@supervacuus
Copy link
Collaborator Author

@JoshuaMoelans, now that we have reviewed it in detail and have a getsentry fork of mini_chromium, can I ask you to have one last look at the submodule chain to double-check for any stupidities on my part? Thx!

Copy link
Member

@JoshuaMoelans JoshuaMoelans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, the chain seems correct! 🚀

@supervacuus supervacuus merged commit 3981ea7 into master Jan 10, 2025
24 checks passed
@supervacuus supervacuus deleted the feat/crashpad_cxx17_support branch January 10, 2025 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Forced C++20 requirement?
2 participants