fix(nextjs): Fix HMR by inserting new entrypoints at the end #9267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lms24
approved these changes
Oct 16, 2023
Comment on lines
588
to
590
| newEntryPoint = isDevMode ? [currentEntryPoint, ...filesToInsert] : [...filesToInsert, currentEntryPoint]; | ||
| } else if (Array.isArray(currentEntryPoint)) { | ||
| newEntryPoint = [...filepaths, ...currentEntryPoint]; | ||
| newEntryPoint = isDevMode ? [...currentEntryPoint, ...filesToInsert] : [...filesToInsert, ...currentEntryPoint]; |
There was a problem hiding this comment.
l: took me a while to understand the cases and object spreads here. Not sure how much we can simplify this but do you think it'd help to use our arrayify utility to basically remove the typeof checks? Although then again I'm not sure what types currentEntryPoint could be of. Feel free to disregard!
AbhiPrasad
approved these changes
Oct 16, 2023
AbhiPrasad
reviewed
Oct 16, 2023
| ): void { | ||
| // BIG FAT NOTE: Order of insertion seems to matter here. If we insert the new files before the `currentEntrypoint`s, the Next.js dev server breaks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9067
The order in which we insert the SDK into the webpack entrypoints seems to matter in dev mode. Maybe the dev init script is somehow referenced by index. 🤷♂️
There is a slight nuanced consideration here in which the SDK may now be initialized too late to catch any errors generated by Next.js which we insert at the end only in dev mode.