Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(utils): Move Node specific ANR impl. out of utils #9258

Merged
merged 1 commit into from
Oct 16, 2023

Conversation

timfish
Copy link
Collaborator

@timfish timfish commented Oct 16, 2023

Closes #9256

Rather than move this all to the Node package, this PR moves only the Node specific code. This means that it might still be possible to use this code for any future browser implementation.

@timfish timfish requested a review from lforst October 16, 2023 10:27
@timfish
Copy link
Collaborator Author

timfish commented Oct 16, 2023

Another alternative would be to just use Date.now() since we don't need high resolution...

Copy link
Member

@lforst lforst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thank you :)

@lforst lforst merged commit 43ed7b0 into getsentry:develop Oct 16, 2023
70 checks passed
@timfish timfish deleted the fix/no-node-in-utils branch October 16, 2023 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Runtime specific API in utils package: process
2 participants