Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tracing): Add tracing without performance to browser and client Sveltekit #8458

Merged
merged 4 commits into from
Jul 6, 2023

Conversation

AbhiPrasad
Copy link
Member

ref #8352

Adds tracing without performance support to

  1. fetch requests in browser
  2. xhr requests in browser
  3. Sveltekit fetch monkeypatching (pulled into this PR because it also uses addTracingHeadersToFetchRequest

@AbhiPrasad AbhiPrasad requested review from a team, mydea and ale-cota and removed request for a team July 5, 2023 17:09
@AbhiPrasad AbhiPrasad self-assigned this Jul 5, 2023
@AbhiPrasad AbhiPrasad added this to the Tracing without Performance milestone Jul 5, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jul 5, 2023

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 21.81 KB (+0.08% 🔺)
@sentry/browser - ES5 CDN Bundle (minified) 68.56 KB (+0.02% 🔺)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 20.11 KB (+0.03% 🔺)
@sentry/browser - ES6 CDN Bundle (minified) 59.81 KB (+0.03% 🔺)
@sentry/browser - Webpack (gzipped + minified) 21.73 KB (+0.1% 🔺)
@sentry/browser - Webpack (minified) 70.94 KB (+0.03% 🔺)
@sentry/react - Webpack (gzipped + minified) 21.75 KB (+0.09% 🔺)
@sentry/nextjs Client - Webpack (gzipped + minified) 50.39 KB (+0.34% 🔺)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 29.95 KB (+0.64% 🔺)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 27.97 KB (+0.58% 🔺)
@sentry/replay ES6 CDN Bundle (gzipped + minified) 49.42 KB (0%)
@sentry/replay - Webpack (gzipped + minified) 43.1 KB (0%)
@sentry/browser + @sentry/tracing + @sentry/replay - ES6 CDN Bundle (gzipped + minified) 69.34 KB (+0.22% 🔺)
@sentry/browser + @sentry/replay - ES6 CDN Bundle (gzipped + minified) 61.67 KB (+0.02% 🔺)

@AbhiPrasad AbhiPrasad changed the title feat(tracing): feat(tracing): Add tracing without performance to browser and client Sveltekit feat(tracing): Add tracing without performance to browser and client Sveltekit Jul 5, 2023
Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, LGTM!

(Fwiw, we might be able to get rid of the additional SvelteKit fetch instrumentation after all. Someone recently pointed out how they managed to instrument window.fetch before Kit. I'll give this a try when I find the time for it but for now this looks good!)

@AbhiPrasad AbhiPrasad merged commit d439fc5 into develop Jul 6, 2023
@AbhiPrasad AbhiPrasad deleted the abhi-twp-browser branch July 6, 2023 12:59
AbhiPrasad added a commit that referenced this pull request Jul 6, 2023
…Sveltekit (#8458)

Adds tracing without performance support to

1. fetch requests in browser
2. xhr requests in browser
3. Sveltekit fetch monkeypatching (pulled into this PR because it also
uses `addTracingHeadersToFetchRequest`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants