Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(sveltekit): Extract propagation context #8428

Merged
merged 1 commit into from
Jun 30, 2023
Merged

Conversation

AbhiPrasad
Copy link
Member

ref #8352

Use the tracingContextFromHeaders helper (first used in #8422) to simplify how trace context is generated by the Sveltekit SDK . Then set the propagation context accordingly.

@AbhiPrasad AbhiPrasad requested a review from Lms24 June 29, 2023 16:57
@AbhiPrasad AbhiPrasad self-assigned this Jun 29, 2023
Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

q: Do we need to adjust things in the client-side SvelteKit fetch instrumentation?
I understand that this PR handles incoming requests/handlers but I'm wondering if we need to adjust from where we take the DSC/tracing data for outgoing requests.

EDIT: Nevermind, this is adressed in the PR description of #8434, i just missed this initially.

@AbhiPrasad AbhiPrasad merged commit 08ddcfb into develop Jun 30, 2023
@AbhiPrasad AbhiPrasad deleted the abhi-twp-sveltekit branch June 30, 2023 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants