Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref(node): Remove raven-node backward-compat code #4942

Merged
merged 1 commit into from
Apr 18, 2022
Merged

ref(node): Remove raven-node backward-compat code #4942

merged 1 commit into from
Apr 18, 2022

Conversation

AbhiPrasad
Copy link
Member

Removes functionality around syncing context from domain.

Resolves https://getsentry.atlassian.net/browse/WEB-825

@AbhiPrasad AbhiPrasad requested review from a team, lforst and Lms24 and removed request for a team April 14, 2022 15:22
lforst
lforst approved these changes Apr 14, 2022
View reviewed changes
Copy link
Member

@lforst lforst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me. Should we write this down somewhere? migration docs?

@AbhiPrasad
Copy link
Member Author

@kamilogorek you think we need migration docs for this?

@github-actions
Copy link
Contributor

github-actions bot commented Apr 14, 2022 •
edited
Loading

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 20.2 KB (+0.29% 🔺)
@sentry/browser - ES5 CDN Bundle (minified) 64.33 KB (-0.44% 🔽)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 18.84 KB (-0.09% 🔽)
@sentry/browser - ES6 CDN Bundle (minified) 57.94 KB (-0.06% 🔽)
@sentry/browser - Webpack (gzipped + minified) 23.41 KB (+0.76% 🔺)
@sentry/browser - Webpack (minified) 81.21 KB (-0.63% 🔽)
@sentry/react - Webpack (gzipped + minified) 23.46 KB (+0.79% 🔺)
@sentry/nextjs Client - Webpack (gzipped + minified) 47.96 KB (-0.19% 🔽)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 26.04 KB (-0.11% 🔽)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 24.42 KB (-0.27% 🔽)

@AbhiPrasad AbhiPrasad force-pushed the v7-abhi-raven-node-rm branch from 91a5905 to d6b3b54 Compare April 18, 2022 15:33
@AbhiPrasad
ref(node): Remove raven-node backward-compat code
f044a28 
Removes functionality around syncing context from domain.
@AbhiPrasad AbhiPrasad force-pushed the v7-abhi-raven-node-rm branch from d6b3b54 to f044a28 Compare April 18, 2022 17:14
@AbhiPrasad AbhiPrasad merged commit 0b2163b into 7.x Apr 18, 2022
@AbhiPrasad AbhiPrasad deleted the v7-abhi-raven-node-rm branch April 18, 2022 17:41
@AbhiPrasad AbhiPrasad added this to the 7.0.0 milestone Apr 25, 2022
Lms24 pushed a commit that referenced this pull request Apr 26, 2022
@AbhiPrasad @Lms24
ref(node): Remove raven-node backward-compat code (#4942)
e7e91ed 
Removes functionality around syncing context from domain.
lobsterkatie pushed a commit that referenced this pull request Apr 26, 2022
@AbhiPrasad @lobsterkatie
ref(node): Remove raven-node backward-compat code (#4942)
8a5de5c 
Removes functionality around syncing context from domain.
lobsterkatie pushed a commit that referenced this pull request Apr 26, 2022
@AbhiPrasad @lobsterkatie
ref(node): Remove raven-node backward-compat code (#4942)
0d811bd 
Removes functionality around syncing context from domain.
AbhiPrasad added a commit that referenced this pull request May 30, 2022
@AbhiPrasad
ref(node): Remove raven-node backward-compat code (#4942)
c1bb439 
Removes functionality around syncing context from domain.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lms24 Lms24 Lms24 approved these changes

@lforst lforst lforst approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
7.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@AbhiPrasad @lforst @Lms24