-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove stack parser support for Opera pre v15 #4923
Merged
AbhiPrasad
merged 16 commits into
getsentry:7.x
from
timfish:v7/remove-pre-opera-v15-parsers
Apr 12, 2022
Merged
Remove stack parser support for Opera pre v15 #4923
AbhiPrasad
merged 16 commits into
getsentry:7.x
from
timfish:v7/remove-pre-opera-v15-parsers
Apr 12, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes all references to `@sentry/apm`, a deprecated package we do not use anymore.
Removes the deprecated `API` class.
Removes `getActiveDomain` function and corresponding type.
The `user` dsn component was renamed to `publicKey`. This PR removes that from the dsn field.
…ntOutgoingRequests (getsentry#4859)
Increases the creation timeout of `MongoMemoryServer` to temporarily fix Node integration test flakiness
This PR removes the previously deprecated `frameContextLines` from `NodeOptions`.
…4887) These exports were historically used in `@sentry/electron`, but are no longer being used by the Electron SDK or the React Native SDK, so they can be removed.
AbhiPrasad
approved these changes
Apr 12, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can remove opera10StackParser
and opera11StackParser
in v8 :)
lobsterkatie
pushed a commit
that referenced
this pull request
Apr 13, 2022
Opera v15 was released in 2013 and was based on Chromium. This PR removes the two Opera specific stack parsers that cater for versions before this from the defaults. Anyone still wanting to support these ancient browser versions can do the following: ```ts import { init, defaultStackParsers, opera10StackParser, opera11StackParser } from '@sentry/browser'; init({ dsn: '__DSN__', stackParser: [...defaultStackParsers, opera10StackParser, opera11StackParser] }) ```
Lms24
pushed a commit
that referenced
this pull request
Apr 26, 2022
Opera v15 was released in 2013 and was based on Chromium. This PR removes the two Opera specific stack parsers that cater for versions before this from the defaults. Anyone still wanting to support these ancient browser versions can do the following: ```ts import { init, defaultStackParsers, opera10StackParser, opera11StackParser } from '@sentry/browser'; init({ dsn: '__DSN__', stackParser: [...defaultStackParsers, opera10StackParser, opera11StackParser] }) ```
lobsterkatie
pushed a commit
that referenced
this pull request
Apr 26, 2022
Opera v15 was released in 2013 and was based on Chromium. This PR removes the two Opera specific stack parsers that cater for versions before this from the defaults. Anyone still wanting to support these ancient browser versions can do the following: ```ts import { init, defaultStackParsers, opera10StackParser, opera11StackParser } from '@sentry/browser'; init({ dsn: '__DSN__', stackParser: [...defaultStackParsers, opera10StackParser, opera11StackParser] }) ```
lobsterkatie
pushed a commit
that referenced
this pull request
Apr 26, 2022
Opera v15 was released in 2013 and was based on Chromium. This PR removes the two Opera specific stack parsers that cater for versions before this from the defaults. Anyone still wanting to support these ancient browser versions can do the following: ```ts import { init, defaultStackParsers, opera10StackParser, opera11StackParser } from '@sentry/browser'; init({ dsn: '__DSN__', stackParser: [...defaultStackParsers, opera10StackParser, opera11StackParser] }) ```
AbhiPrasad
pushed a commit
that referenced
this pull request
May 30, 2022
Opera v15 was released in 2013 and was based on Chromium. This PR removes the two Opera specific stack parsers that cater for versions before this from the defaults. Anyone still wanting to support these ancient browser versions can do the following: ```ts import { init, defaultStackParsers, opera10StackParser, opera11StackParser } from '@sentry/browser'; init({ dsn: '__DSN__', stackParser: [...defaultStackParsers, opera10StackParser, opera11StackParser] }) ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opera v15 was released in 2013 and was based on Chromium.
This PR removes the two Opera specific stack parsers that cater for versions before this from the defaults.
Anyone still wanting to support these ancient browser versions can do the following:
An alternative would be to just remove these parsers completely since I'm kinda doubting anyone is still using these browser....