Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(tracing): Avoid browser tracing initialization on node environment. #3548

Merged
merged 5 commits into from
May 19, 2021
Merged

fix(tracing): Avoid browser tracing initialization on node environment. #3548

merged 5 commits into from
May 19, 2021

Conversation

onurtemizkan
Copy link
Collaborator

Fixes #3522
Related: nodejs/node#37970

@onurtemizkan onurtemizkan requested a review from kamilogorek as a code owner May 15, 2021 22:12
@onurtemizkan onurtemizkan changed the title fix: Avoid tracing initialization on node environment. fix(tracing): Avoid tracing initialization on node environment. May 15, 2021
@onurtemizkan onurtemizkan changed the title fix(tracing): Avoid tracing initialization on node environment. fix(tracing): Avoid browser tracing initialization on node environment. May 15, 2021
@github-actions
Copy link
Contributor

github-actions bot commented May 15, 2021 •
edited
Loading

size-limit report

Path Size
@sentry/browser - CDN Bundle (gzipped) 20.76 KB (+0.01% 🔺)
@sentry/browser - Webpack 21.98 KB (0%)
@sentry/react - Webpack 22.01 KB (0%)
@sentry/browser + @sentry/tracing - CDN Bundle (gzipped) 28.16 KB (+0.05% 🔺)

HazAT
HazAT reviewed May 17, 2021
View reviewed changes
Copy link
Member

@HazAT HazAT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

node 6 tests fails 🤔

@kamilogorek kamilogorek enabled auto-merge (squash) May 17, 2021 11:45
@onurtemizkan
Copy link
Collaborator Author

Fixed by assigning undefined to global.process instead of deleting it.
Ref: jestjs/jest#5159 (comment)

@AbhiPrasad AbhiPrasad disabled auto-merge May 19, 2021 14:11
@AbhiPrasad AbhiPrasad merged commit 1bf5cdd into master May 19, 2021
@AbhiPrasad AbhiPrasad deleted the fix/tracing-avoid-ssr branch May 19, 2021 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HazAT HazAT HazAT left review comments

@AbhiPrasad AbhiPrasad AbhiPrasad approved these changes

@kamilogorek kamilogorek Awaiting requested review from kamilogorek

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Browser tracing also works in server-side rendering with Node.js V16
4 participants
@onurtemizkan @HazAT @AbhiPrasad @kamilogorek