-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
feat(solid): Add support for TanStack Router Solid #17735
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
c097831
to
58e80ed
Compare
Hi @thedanchez, thanks for also contributing the docs. Will take a look after the corresponding PR. |
Hi @andreiborza! Apologies for the delay. I was out of commission with an illness the past few days. Here is the companion docs PR for this feature |
58e80ed
to
cf38998
Compare
Hi @andreiborza, any updates on this PR? |
Hey @andreiborza , just a friendly nudge on this again. Are we able to get this reviewed? Really trying to integrate Sentry into my enterprise Solid app that uses TanStack Router Solid |
Hey @thedanchez just chiming in here – thanks for the contribution! EDIT: @andreiborza will take of landing the rest of this PR, but he's OOO this week! |
Hey @thedanchez, I reviewed the PR and it looks good to me. I just need to make some small adjustments. In the solid sdk, we can mark the router as an optional peer dep so we don't really have to vendor these types in probably. I'm traveling at the moment, I might not get to it until next week. Thanks for the contribution! |
Summary
This PR adds support for TanStack Router Solid. It follows the same outline as the existing implementation of TanStack Router React for Sentry as both TanStack Router flavors are built on the same agnostic foundation.