Skip to content

ref(deno): Adjust mechanism of errors caught by globalHandlersIntegration #17635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 16, 2025
Merged

ref(deno): Adjust mechanism of errors caught by globalHandlersIntegration #17635

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
42df317
ref(deno): Adjust `mechanism` of errors caught by `globalHandlersInte…
Lms24 Sep 15, 2025
1d50f14
changelog
Lms24 Sep 15, 2025
007fb0d
changelog ii
Lms24 Sep 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
- ref(bun): Adjust `mechanism` of errors captured in Bun.serve ([#17616](https://github.com/getsentry/sentry-javascript/pull/17616))
- ref(core): Adjust MCP server error event `mechanism` ([#17622](https://github.com/getsentry/sentry-javascript/pull/17622))
- ref(core): Simplify `linkedErrors` mechanism logic ([#17600](https://github.com/getsentry/sentry-javascript/pull/17600))
- ref(deno): Adjust `mechanism` of errors caught by `globalHandlersIntegration` ([#17635](https://github.com/getsentry/sentry-javascript/pull/17635))
- ref(nextjs): Set more specific event `mechanism`s ([#17543](https://github.com/getsentry/sentry-javascript/pull/17543))
- ref(node-core): Add `mechanism` to cron instrumentations ([#17544](https://github.com/getsentry/sentry-javascript/pull/17544))
- ref(node-core): Add more specific `mechanism.type` to worker thread errors from `childProcessIntegration` ([#17578](https://github.com/getsentry/sentry-javascript/pull/17578))
Expand Down
4 changes: 2 additions & 2 deletions packages/deno/src/integrations/globalhandlers.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ function installGlobalErrorHandler(client: Client): void {
originalException: error,
mechanism: {
handled: false,
type: 'error',
type: 'auto.deno.global_handlers.error',
},
});

Expand Down Expand Up @@ -110,7 +110,7 @@ function installGlobalUnhandledRejectionHandler(client: Client): void {
originalException: error,
mechanism: {
handled: false,
type: 'unhandledrejection',
type: 'auto.deno.global_handlers.unhandledrejection',
Copy link
Member

@s1gr1d s1gr1d Sep 16, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know if we should separate this word here. It was one before, so I guess it's expected to be one word.

Suggested change
type: 'auto.deno.global_handlers.unhandledrejection',
type: 'auto.deno.global_handlers.unhandled_rejection',

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

given that the event is called unhandledrejection, I opted to keep it the same in mechanism type

},
});

Expand Down
Loading