Skip to content

ref: Avoid try-catch with unused parameter #17015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 15, 2025
Merged

Conversation

mydea
Copy link
Member

@mydea mydea commented Jul 15, 2025

Instead, we can just use the parameter-less version of try-catch. In future versions of eslint, this will be disallowed, so extracting this out.

@mydea mydea requested review from RulaKhaled and andreiborza July 15, 2025 11:07
@mydea mydea self-assigned this Jul 15, 2025
@mydea mydea requested a review from a team as a code owner July 15, 2025 11:07
Copy link
Contributor

github-actions bot commented Jul 15, 2025

size-limit report 📦

Path Size % Change Change
@sentry/browser 23.87 kB -0.06% -13 B 🔽
@sentry/browser - with treeshaking flags 22.34 kB -0.05% -9 B 🔽
@sentry/browser (incl. Tracing) 39.73 kB -0.06% -20 B 🔽
@sentry/browser (incl. Tracing, Replay) 77.86 kB -0.03% -16 B 🔽
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 67.6 kB -0.02% -13 B 🔽
@sentry/browser (incl. Tracing, Replay with Canvas) 82.57 kB -0.02% -14 B 🔽
@sentry/browser (incl. Tracing, Replay, Feedback) 94.66 kB -0.03% -21 B 🔽
@sentry/browser (incl. Feedback) 40.56 kB -0.04% -15 B 🔽
@sentry/browser (incl. sendFeedback) 28.55 kB -0.04% -10 B 🔽
@sentry/browser (incl. FeedbackAsync) 33.44 kB -0.05% -14 B 🔽
@sentry/react 25.59 kB -0.05% -11 B 🔽
@sentry/react (incl. Tracing) 41.7 kB -0.05% -20 B 🔽
@sentry/vue 28.29 kB -0.07% -19 B 🔽
@sentry/vue (incl. Tracing) 41.52 kB -0.05% -20 B 🔽
@sentry/svelte 23.89 kB -0.06% -13 B 🔽
CDN Bundle 25.18 kB -0.02% -5 B 🔽
CDN Bundle (incl. Tracing) 39.42 kB -0.05% -18 B 🔽
CDN Bundle (incl. Tracing, Replay) 75.43 kB -0.02% -11 B 🔽
CDN Bundle (incl. Tracing, Replay, Feedback) 80.9 kB -0.02% -10 B 🔽
CDN Bundle - uncompressed 73.45 kB -0.12% -84 B 🔽
CDN Bundle (incl. Tracing) - uncompressed 116.9 kB -0.09% -96 B 🔽
CDN Bundle (incl. Tracing, Replay) - uncompressed 231.07 kB -0.05% -111 B 🔽
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 243.88 kB -0.05% -111 B 🔽
@sentry/nextjs (client) 43.72 kB -0.08% -31 B 🔽
@sentry/sveltekit (client) 40.18 kB -0.05% -18 B 🔽
@sentry/node 167.91 kB -0.01% -16 B 🔽
@sentry/node - without tracing 100.32 kB -0.02% -13 B 🔽
@sentry/aws-serverless 128.47 kB -0.02% -15 B 🔽

View base workflow run

mydea added 4 commits July 15, 2025 16:03
Instead, we can just use the parameter-less version of try-catch.
In future versions of eslint, this will be disallowed, so extracting this out.
@mydea mydea force-pushed the fn/avoid-empty-try-catch branch from 1801737 to fdbb840 Compare July 15, 2025 14:04
@mydea mydea enabled auto-merge (squash) July 15, 2025 14:04
@mydea mydea merged commit 9d92e97 into develop Jul 15, 2025
168 of 169 checks passed
@mydea mydea deleted the fn/avoid-empty-try-catch branch July 15, 2025 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants