Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref(react): Adapt tanstack router type #15241

Merged
merged 1 commit into from
Jan 31, 2025
Merged

ref(react): Adapt tanstack router type #15241

merged 1 commit into from
Jan 31, 2025

Conversation

mydea
Copy link
Member

@mydea mydea commented Jan 31, 2025

We adapted this here but did not adapt the types:
#15235

@mydea mydea requested review from TkDodo and Lms24 January 31, 2025 08:11
@mydea mydea self-assigned this Jan 31, 2025
@mydea mydea mentioned this pull request Jan 31, 2025
Merged
Lms24
Lms24 approved these changes Jan 31, 2025
View reviewed changes
Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks!

TkDodo
TkDodo approved these changes Jan 31, 2025
View reviewed changes
Copy link

@TkDodo TkDodo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, I didn’t know we had a copy of the types 👍

@mydea mydea merged commit 829d4da into develop Jan 31, 2025
71 checks passed
@mydea mydea deleted the fn/adapt-tanstack-type branch January 31, 2025 08:38
Lms24 added a commit that referenced this pull request Jan 31, 2025
@Lms24 @tannerlinsley @mydea
fix(v8/react): From location can be undefined in Tanstack Router Inst…
ef4f210 
…rumentation (#15237)

backport of #15235 and #15241

---------

Co-authored-by: Tanner Linsley <tannerlinsley@gmail.com>
Co-authored-by: Francesco Novy <francesco.novy@sentry.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TkDodo TkDodo TkDodo approved these changes

@Lms24 Lms24 Lms24 approved these changes

Assignees

@mydea mydea

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mydea @TkDodo @Lms24