Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(node): Add openTelemetrySpanProcessors option #14852

Merged
merged 1 commit into from
Dec 30, 2024
Merged

Conversation

mydea
Copy link
Member

@mydea mydea commented Dec 30, 2024

Since provider.addSpanProcessor() is deprecated, we need a new way to add additional span processors.

Fixes #14826

Since `provier.addSpanProcessor()` is deprecated, we need a new way to add additional span processors.
Copy link
Contributor

size-limit report 📦

Path Size % Change Change
@sentry/browser 23 KB - -
@sentry/browser - with treeshaking flags 21.72 KB - -
@sentry/browser (incl. Tracing) 35.54 KB - -
@sentry/browser (incl. Tracing, Replay) 72.8 KB - -
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 63.23 KB - -
@sentry/browser (incl. Tracing, Replay with Canvas) 77.21 KB - -
@sentry/browser (incl. Tracing, Replay, Feedback) 89.6 KB - -
@sentry/browser (incl. Feedback) 39.77 KB - -
@sentry/browser (incl. sendFeedback) 27.62 KB - -
@sentry/browser (incl. FeedbackAsync) 32.38 KB - -
@sentry/react 25.74 KB - -
@sentry/react (incl. Tracing) 38.36 KB - -
@sentry/vue 27.25 KB - -
@sentry/vue (incl. Tracing) 37.41 KB - -
@sentry/svelte 23.17 KB - -
CDN Bundle 24.36 KB - -
CDN Bundle (incl. Tracing) 35.91 KB - -
CDN Bundle (incl. Tracing, Replay) 71 KB - -
CDN Bundle (incl. Tracing, Replay, Feedback) 76.19 KB - -
CDN Bundle - uncompressed 71.41 KB - -
CDN Bundle (incl. Tracing) - uncompressed 106.88 KB - -
CDN Bundle (incl. Tracing, Replay) - uncompressed 220.95 KB - -
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 233.82 KB - -
@sentry/nextjs (client) 38.66 KB - -
@sentry/sveltekit (client) 36.08 KB - -
@sentry/node 162.17 KB +0.02% +25 B 🔺
@sentry/node - without tracing 98.91 KB +0.03% +26 B 🔺
@sentry/aws-serverless 128.74 KB +0.03% +28 B 🔺

View base workflow run

Copy link
Member

@AbhiPrasad AbhiPrasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we backport this? Edit: I completely ignored the other PR 😅

mydea added a commit that referenced this pull request Dec 30, 2024
@mydea mydea merged commit 458dca4 into develop Dec 30, 2024
138 checks passed
@mydea mydea deleted the fn/span-processors branch December 30, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to pass additional span processors to OTEL Node client
2 participants