Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nextjs): Fix matching logic for file convention type for root level components #14038

Merged
merged 9 commits into from
Oct 22, 2024

Conversation

lforst
Copy link
Member

@lforst lforst commented Oct 21, 2024

We had some instances of unknown page server component being recorded because we were passing page.tsx instead of /page.tsx to the matching regex and the regex always matched for a leading slash.

Copy link

codecov bot commented Oct 21, 2024

❌ 8 Tests Failed:

Tests completed Failed Passed Skipped
232 8 224 4
View the top 3 failed tests by shortest run time
server-components.test.ts Should set a "not_found" status on a server component span when notFound() is called and the request span should have status ok
Stack Traces | 0.236s run time
server-components.test.ts:69:5 Should set a "not_found" status on a server component span when notFound() is called and the request span should have status ok
generation-functions.test.ts Should send a transaction and an error event for a faulty generateViewport() function invokation
Stack Traces | 0.243s run time
generation-functions.test.ts:86:5 Should send a transaction and an error event for a faulty generateViewport() function invokation
server/server-component-error.test.ts Should capture an error thrown in a server component
Stack Traces | 0.281s run time
server-component-error.test.ts:4:5 Should capture an error thrown in a server component

To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard

@lforst lforst requested a review from chargome October 21, 2024 14:44
@lforst lforst merged commit 5b22b26 into develop Oct 22, 2024
144 checks passed
@lforst lforst deleted the lforst-root-lvl-components branch October 22, 2024 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants