Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Use PAT for external contributor PR #13888

Merged
merged 1 commit into from
Oct 7, 2024
Merged

ci: Use PAT for external contributor PR #13888

merged 1 commit into from
Oct 7, 2024

Conversation

mydea
Copy link
Member

@mydea mydea commented Oct 7, 2024

I noticed multiple times, e.g. #13883, that the external contributor PRs do not trigger CI automatically.

I think this is because stuff that is triggered by GITHUB_TOKEN does not trigger CI. So I am updating this to use the repo scoped token instead, let's see if that works.

@mydea mydea requested review from Lms24 and chargome October 7, 2024 10:55
@mydea mydea self-assigned this Oct 7, 2024
Copy link
Member

@chargome chargome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we leave the name in the comment? 😄

@mydea
Copy link
Member Author

mydea commented Oct 7, 2024

Should we leave the name in the comment? 😄

This makes sense I think because you'll see Daniel as the one who opens the PR :D

@mydea mydea merged commit c2c8be9 into develop Oct 7, 2024
150 checks passed
@mydea mydea deleted the fn/use-pat branch October 7, 2024 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants