fix(astro): Correctly extract request data #13315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lms24
changed the base branch from
develop
to
lms/fix-astro-request-headers-dynamic-page-reqs
mydea
approved these changes
Aug 12, 2024
Base automatically changed from
lms/fix-astro-request-headers-dynamic-page-reqs
to
develop
August 12, 2024 11:49
Lms24
force-pushed
the
lms/fix-astro-extract-request-data
branch
from
cef44dd to
a24cebc
Compare
This was referenced Sep 4, 2024
This was referenced Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
builds on top of #13306, found while working on #13116
This PR ensures that we correctly extract the request data in our Astro middleware. Previously we didn't convert the
request.headersobject into aRecord<string, string>but simply passed aHeadersinstance. This caused problems with therequestDataIntegrationwhich doesn't handle the instance correctly.