fix(nuxt): Detect pageload by adding flag in Vue router #13171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s1gr1d
commented
Aug 2, 2024
Comment on lines
+11
to
+13
| /* Make sure to import from '@nuxt/test-utils/playwright' in the tests | ||
| * Like this: import { expect, test } from '@nuxt/test-utils/playwright' */ | ||
|
|
There was a problem hiding this comment.
Added this just as a heads-up in case someone adds new tests later on.
Lms24
approved these changes
Aug 2, 2024
packages/vue/src/router.ts
Outdated
| @@ -50,18 +50,27 @@ export function instrumentVueRouter( | |||
| }, | |||
| startNavigationSpanFn: (context: StartSpanOptions) => void, | |||
| ): void { | |||
| let IS_FIRST_PAGE_LOAD = true; | |||
There was a problem hiding this comment.
l: Given that this is not a constant, I'd say we don't capitalize the variable name
size-limit report 📦
|
mydea
reviewed
Aug 5, 2024
| @@ -26,8 +28,8 @@ export function init(options: SentryNuxtOptions): Client | undefined { | |||
| // todo: the buildAssetDir could be changed in the nuxt config - change this to a more generic solution | |||
| if (event.transaction?.match(/^GET \/_nuxt\//)) { | |||
| options.debug && | |||
| // eslint-disable-next-line no-console | |||
| console.log('[Sentry] NuxtLowQualityTransactionsFilter filtered transaction: ', event.transaction); | |||
| DEBUG_BUILD && | |||
mydea
approved these changes
Aug 5, 2024
This was referenced Aug 27, 2024
This was referenced Aug 28, 2024
This was referenced Aug 29, 2024
This was referenced Aug 30, 2024
This was referenced Aug 30, 2024
This was referenced Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nuxt is using the Vue router under the hood, but the previous condition to detect a page load (
from.name == null && from.matched.length === 0) does not work with Nuxt, asfrom.matchedis never empty.