-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(browser): Avoid showing browser extension error message in non-window
global scopes
#13156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
window
global scopes
chargome
approved these changes
Aug 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still think that's ok given that a worker never has access to window
👍
ddomonkos
approved these changes
Aug 1, 2024
mydea
approved these changes
Aug 2, 2024
3 tasks
…ndow browser environments
8283618
to
c4f7e47
Compare
This was referenced Aug 27, 2024
This was referenced Aug 28, 2024
This was referenced Aug 29, 2024
This was referenced Aug 30, 2024
This was referenced Aug 30, 2024
This was referenced Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR relaxes our browser extension detection check. The idea is to avoid showing the error message and blocking
Sentry.init
if the SDK is not initialized in awindow
global scope. For instance, this will allowSentry.init
to be executed in (service) workers. We likely don't need to worry about multiple SDK instance collisions in non-window
global scopes.We discussed this a bit internally and there are some caveats to this. Using the browser SDK in workers is a bit problematic as many global APIs are not available in there. However, we currently instruct users to do just that. Long-term, it'd be valuable to have a worker SDK that doesn't expect certain browser/Window APIs to be present at all.
Reviewers, please roast me if this is not a good idea :D
fixes #13152