-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(node): Send client reports #12951
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
cb11d4c
to
b3008b6
Compare
mydea
approved these changes
Jul 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice work!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #12822
This PR adds client reports to the Node.js SDK.
Client reports must be enabled via the
startClientReportTracking()
method on theNodeClient
. This is due to the fact that client reports (or rather thesetInterval
that is required for periodically sending them) is acquiring a resource that needs cleanup. If somebody were to create clients over and over again, without callingclient.close()
they would be leaking memory.If
startClientReportTracking()
is called, the client will flush all client reportsprocess.on('beforeExit')
, which is when the event loop has run out of things to do.Out of the box, the Node.js SDK's
Sentry.init()
will callstartClientReportTracking()
, since there we can assume that users are using a singular client.We are also introducing a new option for the Node.js SDK called
clientReportFlushInterval
that will control the flush interval of the periodic client report flushing.