Align Span interface with changes in Otel Span interface
#12566
Assignees
Comments
mydea
added a commit
that referenced
this issue
Jun 20, 2024
With this PR, you can now pass a `parentSpan` optionally to `startSpan*`
APIs to create a span as a child of a specific span:
```js
const span = Sentry.startInactiveSpan({ name: 'xxx', parentSpan: parent });
Sentry.startSpan({ name: 'xxx', parentSpan: parent }, () => {});
Sentry.startSpanManual({ name: 'xxx', parentSpan: parent }, () => {});
```
With this, it should be easier to understand how you can manually work
with spans in v8.
Closes #12539
ref #12566, which I
noticed while working on this. For now I just cast the span which should
be fine, but is not ideal.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
There are three methods in the OTEL Span interface that we do not have in our own, leading to technical incompatibility - see https://github.com/open-telemetry/opentelemetry-js/blob/main/api/src/trace/span.ts
addLink- should noop in SentrySpanaddLinks- should noop in SentrySpanrecordException- should probably capture an exception??Without this, you technically can't pass something typed as
Spanfrom@sentry/typesinto some API that expects an OTEL span.The text was updated successfully, but these errors were encountered: