fix(browser): 0 is a valid index (#8581)

getsentry · Jul 19, 2023 · 68c4491 · 68c4491
1 parent f2bdd1f
commit 68c4491
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/packages/browser/src/profiling/utils.ts b/packages/browser/src/profiling/utils.ts
@@ -249,9 +249,9 @@ export function convertJSSelfProfileToSampledFormat(input: JSSelfProfile): Profi
       if (profile.frames[stackTop.frameId] === undefined) {
         profile.frames[stackTop.frameId] = {
           function: frame.name,
-          file: frame.resourceId ? input.resources[frame.resourceId] : undefined,
-          line: frame.line,
-          column: frame.column,
+          abs_path: typeof frame.resourceId === 'number' ? input.resources[frame.resourceId] : undefined,
+          lineno: frame.line,
+          colno: frame.column,
         };
       }
 

diff --git a/packages/types/src/profiling.ts b/packages/types/src/profiling.ts
@@ -14,8 +14,9 @@ export type ThreadCpuStack = FrameId[];
 export type ThreadCpuFrame = {
   function: string;
   file?: string;
-  line?: number;
-  column?: number;
+  lineno?: number;
+  colno?: number;
+  abs_path?: string;
 };
 
 export interface ThreadCpuProfile {