Avoid logging an error when a float is passed in the manifest #4031
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
Avoid logging an error when a float is passed in the manifest
#3823 added support for integer values in the manifest.
But that's used as default value when parsing floats. This means that all float values are evaluated as integers and floats, causing one of the checks to fail.
Everything still works correctly, but when the type is wrong, the error is logged in the logcat.
This PR avoids the log if the value passed in the manifest is a float
💡 Motivation and Context
Closes getsentry/sentry-android-gradle-plugin#803
💚 How did you test it?
📝 Checklist
sendDefaultPII
is enabled.🔮 Next steps