Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid logging an error when a float is passed in the manifest #4031

Merged
merged 5 commits into from
Jan 22, 2025

Conversation

stefanosiano
Copy link
Member

📜 Description

Avoid logging an error when a float is passed in the manifest

#3823 added support for integer values in the manifest.
But that's used as default value when parsing floats. This means that all float values are evaluated as integers and floats, causing one of the checks to fail.
Everything still works correctly, but when the type is wrong, the error is logged in the logcat.
This PR avoids the log if the value passed in the manifest is a float

💡 Motivation and Context

Closes getsentry/sentry-android-gradle-plugin#803

💚 How did you test it?

📝 Checklist

  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

@stefanosiano stefanosiano marked this pull request as ready for review January 8, 2025 11:08
Copy link
Contributor

github-actions bot commented Jan 8, 2025

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 406.42 ms 455.29 ms 48.87 ms
Size 1.65 MiB 2.31 MiB 677.59 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
00c8eeb 415.32 ms 428.08 ms 12.76 ms

App size

Revision Plain With Sentry Diff
00c8eeb 1.70 MiB 2.36 MiB 671.98 KiB

Previous results on branch: fix/avoid-log-floats

Startup times

Revision Plain With Sentry Diff
8afb0d4 450.78 ms 483.59 ms 32.80 ms
9e5d3c8 465.39 ms 493.20 ms 27.81 ms
ecbb096 389.02 ms 456.79 ms 67.77 ms

App size

Revision Plain With Sentry Diff
8afb0d4 1.65 MiB 2.31 MiB 677.57 KiB
9e5d3c8 1.65 MiB 2.31 MiB 677.59 KiB
ecbb096 1.65 MiB 2.31 MiB 677.59 KiB

Base automatically changed from 8.x.x to main January 9, 2025 15:47
@romtsn
Copy link
Member

romtsn commented Jan 16, 2025

@stefanosiano @adinauer wanted to hold off with merging PRs to v8, so you could wait until next week (or convince Alex :)) to merge the PR.

@stefanosiano stefanosiano enabled auto-merge (squash) January 21, 2025 15:42
@stefanosiano stefanosiano disabled auto-merge January 21, 2025 15:43
@stefanosiano stefanosiano enabled auto-merge (squash) January 22, 2025 11:55
@stefanosiano stefanosiano disabled auto-merge January 22, 2025 11:56
@stefanosiano stefanosiano requested a review from lcian as a code owner January 22, 2025 15:56
@stefanosiano stefanosiano enabled auto-merge (squash) January 22, 2025 15:56
@stefanosiano stefanosiano merged commit 830e57d into main Jan 22, 2025
38 checks passed
@stefanosiano stefanosiano deleted the fix/avoid-log-floats branch January 22, 2025 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sample-rate configuration from Manifest does not work
2 participants