Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable ThreadLocalAccessor for Spring Boot 3 WebFlux by default #4023

Merged
merged 2 commits into from
Jan 7, 2025

Conversation

adinauer
Copy link
Member

@adinauer adinauer commented Jan 7, 2025

📜 Description

Change default for sentry.reactive.thread-local-accessor-enabled when the property is missing to use ThreadLocalAccessor by default.

💡 Motivation and Context

Closes #4020

💚 How did you test it?

📝 Checklist

  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

Copy link
Contributor

github-actions bot commented Jan 7, 2025

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 86052e4

Copy link
Contributor

github-actions bot commented Jan 7, 2025

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 397.11 ms 426.00 ms 28.89 ms
Size 1.65 MiB 2.31 MiB 677.57 KiB

Previous results on branch: feat/webflux-thread-local-accessor-default

Startup times

Revision Plain With Sentry Diff
4281f14 409.46 ms 527.63 ms 118.17 ms

App size

Revision Plain With Sentry Diff
4281f14 1.65 MiB 2.31 MiB 677.57 KiB

Copy link
Collaborator

@lbloder lbloder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@adinauer adinauer merged commit a509828 into 8.x.x Jan 7, 2025
35 checks passed
@adinauer adinauer deleted the feat/webflux-thread-local-accessor-default branch January 7, 2025 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants