Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SR] Allow overriding SdkVersion only for replay events #4014

Merged
merged 14 commits into from
Dec 30, 2024
Merged

[SR] Allow overriding SdkVersion only for replay events #4014

merged 14 commits into from
Dec 30, 2024

Conversation

romtsn
Copy link
Member

@romtsn romtsn commented Dec 30, 2024

📜 Description

  • Adds another SdkVersion to SentryReplayOptions which can be overridden by the Hybrid SDKs and used only for replay events and envelopes

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

@romtsn romtsn requested a review from vaind December 30, 2024 16:55
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 30, 2024 •
edited
Loading

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 372.43 ms 445.70 ms 73.27 ms
Size 1.70 MiB 2.36 MiB 671.90 KiB

Previous results on branch: rz/feat/session-replay-override-sdk-version

Startup times

Revision Plain With Sentry Diff
dca9c27 407.20 ms 427.61 ms 20.41 ms

App size

Revision Plain With Sentry Diff
dca9c27 1.70 MiB 2.36 MiB 671.90 KiB

stefanosiano
stefanosiano approved these changes Dec 30, 2024
View reviewed changes
Copy link
Member

@stefanosiano stefanosiano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

vaind
vaind approved these changes Dec 30, 2024
View reviewed changes
Copy link
Collaborator

@vaind vaind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@romtsn romtsn enabled auto-merge (squash) December 30, 2024 21:24
@romtsn romtsn merged commit 75ebe50 into main Dec 30, 2024
32 checks passed
@romtsn romtsn deleted the rz/feat/session-replay-override-sdk-version branch December 30, 2024 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefanosiano stefanosiano stefanosiano approved these changes

@vaind vaind vaind approved these changes

@adinauer adinauer Awaiting requested review from adinauer adinauer is a code owner

@markushi markushi Awaiting requested review from markushi markushi is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@romtsn @vaind @stefanosiano