Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

POTEL 71 - Add scopeBindingMode to SpanOptions #4004

Merged
merged 30 commits into from
Dec 20, 2024
Merged

Conversation

adinauer
Copy link
Member

📜 Description

Add scopeBindingMode to SpanOptions

💡 Motivation and Context

Grant control over whether a new span created with OpenTelemetry active should be added to the current scope or not.

💚 How did you test it?

📝 Checklist

  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

adinauer and others added 28 commits December 6, 2024 10:10
@adinauer adinauer requested a review from markushi as a code owner December 20, 2024 07:54
Copy link
Contributor

github-actions bot commented Dec 20, 2024

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 524e096

Copy link
Contributor

github-actions bot commented Dec 20, 2024

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 413.20 ms 469.82 ms 56.62 ms
Size 1.65 MiB 2.31 MiB 677.57 KiB

Previous results on branch: feat/scope-binding-mode

Startup times

Revision Plain With Sentry Diff
ee396b8 443.68 ms 516.07 ms 72.38 ms
0ff2534 411.13 ms 437.46 ms 26.33 ms

App size

Revision Plain With Sentry Diff
ee396b8 1.65 MiB 2.31 MiB 677.28 KiB
0ff2534 1.65 MiB 2.31 MiB 677.28 KiB

Copy link
Collaborator

@lbloder lbloder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Base automatically changed from feat/agentless-spring-module to 8.x.x December 20, 2024 10:53
@adinauer adinauer merged commit f4e2d80 into 8.x.x Dec 20, 2024
30 checks passed
@adinauer adinauer deleted the feat/scope-binding-mode branch December 20, 2024 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants