Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] fix console samples #3979

Draft
wants to merge 10 commits into
base: feat/update-otel-sample-readme
Choose a base branch
from

Conversation

lbloder
Copy link
Collaborator

@lbloder lbloder commented Dec 10, 2024

📜 Description

Fixes the sentry console samples

💡 Motivation and Context

The sentry-samples-console-opentelemetry-noagent sample did not produce any spans.

💚 How did you test it?

📝 Checklist

  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

Copy link
Contributor

github-actions bot commented Dec 10, 2024

Fails
🚫 Please consider adding a changelog entry for the next release.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

## Unreleased

- [WIP] fix console samples ([#3979](https://github.com/getsentry/sentry-java/pull/3979))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description.

Generated by 🚫 dangerJS against ca4cb47

Copy link
Contributor

github-actions bot commented Dec 10, 2024

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 466.04 ms 481.19 ms 15.15 ms
Size 1.65 MiB 2.31 MiB 677.57 KiB

Previous results on branch: fix/fix-console-samples

Startup times

Revision Plain With Sentry Diff
6ebd7bb 415.76 ms 489.13 ms 73.36 ms
8902d25 383.02 ms 387.58 ms 4.56 ms
d035e4a 323.87 ms 361.86 ms 37.99 ms
15316ed 429.28 ms 439.04 ms 9.76 ms
42a4b98 419.52 ms 468.80 ms 49.27 ms

App size

Revision Plain With Sentry Diff
6ebd7bb 1.65 MiB 2.31 MiB 677.56 KiB
8902d25 1.65 MiB 2.31 MiB 676.08 KiB
d035e4a 1.65 MiB 2.31 MiB 676.08 KiB
15316ed 1.65 MiB 2.31 MiB 676.08 KiB
42a4b98 1.65 MiB 2.31 MiB 676.08 KiB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants