Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(release): Replace release bot with GH app #3975

Merged
merged 2 commits into from
Dec 16, 2024

Conversation

Jeffreyhung
Copy link
Member

@Jeffreyhung Jeffreyhung commented Dec 9, 2024

The getsentry-release is a GitHub bot account that is used in various automation, and the ${{ secrets.GH_RELEASE_PAT }} is a personal access token from that bot account. We are using a regular GitHub account as a bot while it should be a non-human account since there are no humans behind it. Hence, we are replacing it with a GitHub App.

Functionality wise, there will be no difference.

More details: https://www.notion.so/sentry/DACI-Replace-GitHub-bot-accounts-with-GitHub-Apps-getsentry-release-15109965d1204a91b9be71c49e8b66e0?pvs=4

#skip-changelog

Copy link
Contributor

github-actions bot commented Dec 9, 2024

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against b123fe3

Copy link
Contributor

github-actions bot commented Dec 9, 2024

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 394.18 ms 414.13 ms 19.95 ms
Size 1.70 MiB 2.36 MiB 672.21 KiB

Previous results on branch: Replace-release-bot-with-GH-app

Startup times

Revision Plain With Sentry Diff
c04e5f7 384.60 ms 449.96 ms 65.35 ms

App size

Revision Plain With Sentry Diff
c04e5f7 1.70 MiB 2.36 MiB 672.11 KiB

@Jeffreyhung Jeffreyhung enabled auto-merge (squash) December 9, 2024 23:44
@Jeffreyhung Jeffreyhung requested a review from BYK December 9, 2024 23:45
@Jeffreyhung Jeffreyhung merged commit 90eb1e3 into main Dec 16, 2024
33 checks passed
@Jeffreyhung Jeffreyhung deleted the Replace-release-bot-with-GH-app branch December 16, 2024 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants