[SR] Fix various crashes

[romtsn]

📜 Description

• Fix IndexOutOfBoundsException when tracking window changes. The problem here was that we had an object RootViewSpy, and it was shared between different instances of the ReplayIntegration, hence messing up things.
• Fix IllegalStateException when adding/removing draw listener for a dead view
• Fix ConcurrentModificationException when registering window listeners and stopping WindowRecorder/GestureRecorder
• Fix some TODOs in Windows.kt

💡 Motivation and Context

Closes #3859
Closes getsentry/sentry-react-native#4234

💚 How did you test it?

Manually + automated

📝 Checklist

• I added tests to verify the changes.
• No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
• I updated the docs if needed.
• I updated the wizard if needed.
• Review from the native team if needed.
• No breaking change or entry added to the changelog.
• No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

[github-actions]

Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	431.15 ms	499.96 ms	68.81 ms
Size	1.70 MiB	2.36 MiB	672.22 KiB

Previous results on branch: rz/fix/session-replay-window-crashes

Startup times

Revision	Plain	With Sentry	Diff
c4a83e5	413.86 ms	464.82 ms	50.96 ms
68f8bfc	414.88 ms	428.41 ms	13.53 ms
113888d	441.10 ms	491.92 ms	50.82 ms

App size

Revision	Plain	With Sentry	Diff
c4a83e5	1.70 MiB	2.35 MiB	669.67 KiB
68f8bfc	1.70 MiB	2.35 MiB	669.68 KiB
113888d	1.70 MiB	2.35 MiB	669.67 KiB

[markushi]

LGTM!

[iamrita]

Thanks for fixing this! What version of sentry should we update to on Android to incorporate this change?

[markushi]

@iamrita This fix will ship as part of the 7.19.0 release, which is about to ship in the upcoming hours.

[iamrita]

Great, looking forward to it!

[iamrita]

@markushi Any update on the 7.19.0 release?

[markushi]

@iamrita sorry for the delay, there was a small hiccup with our release pipeline, but the release is out now!