Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

POTEL 59 - Bump OpenTelemetry #3935

Merged
merged 4 commits into from
Nov 29, 2024
Merged

POTEL 59 - Bump OpenTelemetry #3935

merged 4 commits into from
Nov 29, 2024

Conversation

adinauer
Copy link
Member

📜 Description

Bump OpenTelemetry SDK to 1.44.1, OpenTelemetry instrumentation to 2.10.0 and OpenTelemetry semantic conventions to 1.28.0

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

Copy link
Contributor

github-actions bot commented Nov 28, 2024

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against ad9b417

Copy link
Contributor

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 388.68 ms 456.61 ms 67.93 ms
Size 1.65 MiB 2.31 MiB 676.03 KiB

Copy link
Member

@stefanosiano stefanosiano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

from what i can tell it's fine
I guess the move of the dependencyManagement block to the noagent gradle file is wanted, right? 😅

Copy link
Collaborator

@lbloder lbloder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@lbloder
Copy link
Collaborator

lbloder commented Nov 29, 2024

@adinauer The system tests seem to be failing though

@lbloder
Copy link
Collaborator

lbloder commented Nov 29, 2024

@adinauer The system tests seem to be failing though

Never mind, seems to be fixed in #3938

@adinauer
Copy link
Member Author

Yes, some tests were failing because "no agent" didn't work with the new OTel version. It's fixed in the POTEL 60 PR.

@adinauer
Copy link
Member Author

I guess the move of the dependencyManagement block to the noagent gradle file is wanted, right?

Yes, this is intentional as OTel suggests to add this config when using the spring boot otel starter.

@adinauer adinauer merged commit 7345b18 into 8.x.x Nov 29, 2024
33 of 35 checks passed
@adinauer adinauer deleted the feat/bump-otel-2-10-0 branch November 29, 2024 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants