Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(Android) Enable Performance V2 by default #3824

Merged
merged 3 commits into from
Oct 28, 2024
Merged

(Android) Enable Performance V2 by default #3824

merged 3 commits into from
Oct 28, 2024

Conversation

stefanosiano
Copy link
Member

📜 Description

Performance V2 is enabled by default

💡 Motivation and Context

Closes #3563

💚 How did you test it?

Unit tests

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 25, 2024 •
edited
Loading

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against dfc7dba

@stefanosiano stefanosiano marked this pull request as ready for review October 25, 2024 14:28
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 25, 2024 •
edited
Loading

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 426.94 ms 449.47 ms 22.53 ms
Size 1.70 MiB 2.36 MiB 671.40 KiB

@stefanosiano stefanosiano merged commit d590d3e into 8.x.x Oct 28, 2024
21 of 22 checks passed
@stefanosiano stefanosiano deleted the feat/enable-perfv2-default branch October 28, 2024 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adinauer adinauer adinauer approved these changes

@markushi markushi markushi approved these changes

@romtsn romtsn Awaiting requested review from romtsn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stefanosiano @markushi @adinauer