-
-
Notifications
You must be signed in to change notification settings - Fork 443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace Android thread id with kernel thread id in span data #3706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added getCurrentThreadId() to IThreadChecker replaced thread id of SentryTracer and PerformanceAndroidEventProcessor
Most changes come from renaming IMainThreadChecker to IThreadChecker. |
stefanosiano
commented
Sep 20, 2024
stefanosiano
requested review from
adinauer,
romtsn and
markushi
as code owners
September 20, 2024 14:46
Performance metrics 🚀
|
romtsn
reviewed
Sep 23, 2024
...ry-android-core/src/main/java/io/sentry/android/core/internal/util/AndroidThreadChecker.java
Outdated
Show resolved
Hide resolved
romtsn
approved these changes
Sep 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just a couple of comments around mainThreadId
…ethod renamed AndroidThreadChecker.mainThreadId to mainThreadSystemId
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
renamed IMainThreadChecker to IThreadChecker
added getCurrentThreadSystemId() to IThreadChecker
replaced thread id of SentryTracer and PerformanceAndroidEventProcessor
Adding to v8, since it's a behavioural change and users could already use it in some dashboard, as it's indexed. This is very unlikely, though.
💡 Motivation and Context
Continuous profiler needs to bind the trace and span to the corresponding thread in the profile.
The Android profiler retrieves the kernel thread id, that we can get via
Process.myTid()
, so we have to set that instead ofThread.getThreadId()
💚 How did you test it?
📝 Checklist
sendDefaultPII
is enabled.🔮 Next steps