Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

POTEL 31 - Use span id of remote parent #3548

Merged
merged 3 commits into from
Jul 5, 2024

Conversation

adinauer
Copy link
Member

@adinauer adinauer commented Jul 4, 2024

📜 Description

Set parentSpanId when continuing a trace from an incoming request or other remote span.

💡 Motivation and Context

Traces were broken because on an incoming request, OtelSentrySpanProcessor did not set the parentSpanId on the span correctly. Traces were not referencing the actual parent span but some other (random) span ID which the server doesn't know.

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

Copy link
Contributor

github-actions bot commented Jul 4, 2024

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against f66ae73

Copy link
Contributor

github-actions bot commented Jul 4, 2024

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 383.69 ms 458.09 ms 74.40 ms
Size 1.70 MiB 2.29 MiB 599.21 KiB

Baseline results on branch: 8.x.x

Startup times

Revision Plain With Sentry Diff
57732e8 435.66 ms 510.50 ms 74.84 ms
a0f7731 357.02 ms 433.40 ms 76.38 ms
41e496a 408.90 ms 491.32 ms 82.42 ms
a59fca2 560.08 ms 658.80 ms 98.71 ms

App size

Revision Plain With Sentry Diff
57732e8 1.70 MiB 2.29 MiB 599.77 KiB
a0f7731 1.70 MiB 2.29 MiB 599.77 KiB
41e496a 1.70 MiB 2.29 MiB 599.77 KiB
a59fca2 1.70 MiB 2.29 MiB 599.77 KiB

Previous results on branch: feat/potel-31-use-remote-parent-span-id

Startup times

Revision Plain With Sentry Diff
fee2843 408.09 ms 504.83 ms 96.74 ms

App size

Revision Plain With Sentry Diff
fee2843 1.70 MiB 2.29 MiB 599.77 KiB

Copy link
Collaborator

@lbloder lbloder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@adinauer adinauer merged commit 30fd3cf into 8.x.x Jul 5, 2024
19 of 21 checks passed
@adinauer adinauer deleted the feat/potel-31-use-remote-parent-span-id branch July 5, 2024 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants