POTEL 31 - Use span id of remote parent #3548
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
Set
parentSpanId
when continuing a trace from an incoming request or other remote span.💡 Motivation and Context
Traces were broken because on an incoming request,
OtelSentrySpanProcessor
did not set theparentSpanId
on the span correctly. Traces were not referencing the actual parent span but some other (random) span ID which the server doesn't know.💚 How did you test it?
📝 Checklist
sendDefaultPII
is enabled.🔮 Next steps