Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed sentry-android-okhttp module #3510

Merged
merged 4 commits into from
Jul 1, 2024
Merged

Removed sentry-android-okhttp module #3510

merged 4 commits into from
Jul 1, 2024

Conversation

stefanosiano
Copy link
Member

📜 Description

Removed sentry-android-okhttp module

💡 Motivation and Context

Implements last task of getsentry/sentry-android-gradle-plugin#601
Closes #3369

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 24, 2024 •
edited
Loading

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 2226c96

@stefanosiano stefanosiano marked this pull request as ready for review June 25, 2024 10:15
markushi
markushi approved these changes Jul 1, 2024
View reviewed changes
Copy link
Member

@markushi markushi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@stefanosiano stefanosiano merged commit 935bb1d into 8.x.x Jul 1, 2024
20 of 21 checks passed
@stefanosiano stefanosiano deleted the feat/remove-sentry-android-okhttp branch July 1, 2024 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markushi markushi markushi approved these changes

@adinauer adinauer Awaiting requested review from adinauer

@romtsn romtsn Awaiting requested review from romtsn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stefanosiano @markushi