Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MonitorConfig param to CheckInUtils.withCheckIn #3038

Merged
merged 5 commits into from
Nov 16, 2023

Conversation

adinauer
Copy link
Member

@adinauer adinauer commented Nov 8, 2023

📜 Description

Add MonitorConfig param to CheckInUtils.withCheckIn.

💡 Motivation and Context

This makes it easier to perform upserts.

💚 How did you test it?

Unit Test.

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

Copy link
Contributor

github-actions bot commented Nov 8, 2023

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 82c8bab

Copy link
Contributor

github-actions bot commented Nov 8, 2023

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 362.62 ms 433.51 ms 70.89 ms
Size 1.72 MiB 2.29 MiB 578.38 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
283d83e 348.44 ms 392.06 ms 43.62 ms
c7e2fbc 377.85 ms 426.35 ms 48.50 ms
93a76ca 391.54 ms 475.65 ms 84.11 ms
86f0096 371.86 ms 439.78 ms 67.92 ms
93a76ca 377.96 ms 447.52 ms 69.56 ms
c7e2fbc 398.35 ms 468.52 ms 70.17 ms
c3f503e 360.41 ms 434.67 ms 74.27 ms
a3c77bc 375.80 ms 445.85 ms 70.06 ms
99a51e2 405.11 ms 479.65 ms 74.54 ms
3d8bd2b 375.34 ms 446.32 ms 70.98 ms

App size

Revision Plain With Sentry Diff
283d83e 1.72 MiB 2.29 MiB 577.69 KiB
c7e2fbc 1.72 MiB 2.29 MiB 576.40 KiB
93a76ca 1.72 MiB 2.29 MiB 576.75 KiB
86f0096 1.72 MiB 2.29 MiB 576.50 KiB
93a76ca 1.72 MiB 2.29 MiB 576.75 KiB
c7e2fbc 1.72 MiB 2.29 MiB 576.40 KiB
c3f503e 1.72 MiB 2.29 MiB 577.04 KiB
a3c77bc 1.72 MiB 2.29 MiB 577.53 KiB
99a51e2 1.72 MiB 2.29 MiB 576.34 KiB
3d8bd2b 1.72 MiB 2.29 MiB 577.53 KiB

Previous results on branch: feat/check-in-wrapper-upsert

Startup times

Revision Plain With Sentry Diff
28e0c86 396.16 ms 491.78 ms 95.62 ms
e5fee01 374.75 ms 452.33 ms 77.58 ms

App size

Revision Plain With Sentry Diff
28e0c86 1.72 MiB 2.29 MiB 577.53 KiB
e5fee01 1.72 MiB 2.29 MiB 577.53 KiB

@adinauer
Copy link
Member Author

adinauer commented Nov 8, 2023

Copy link
Collaborator

@lbloder lbloder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

sentry/src/test/java/io/sentry/util/CheckInUtilsTest.kt Outdated Show resolved Hide resolved
@adinauer adinauer merged commit 8c11638 into main Nov 16, 2023
@adinauer adinauer deleted the feat/check-in-wrapper-upsert branch November 16, 2023 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants