Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track auto-init usage in manifest #2795

Merged
merged 6 commits into from
Jun 22, 2023
Merged

Track auto-init usage in manifest #2795

merged 6 commits into from
Jun 22, 2023

Conversation

romtsn
Copy link
Member

@romtsn romtsn commented Jun 22, 2023

📜 Description

  • Adds AutoInit to the integrations list

💡 Motivation and Context

We would like to understand how often manifest is used versus manual init in code.

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

@github-actions
Copy link
Contributor

github-actions bot commented Jun 22, 2023

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 334.84 ms 393.55 ms 58.71 ms
Size 1.72 MiB 2.28 MiB 573.45 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
496bdfd 272.86 ms 407.33 ms 134.48 ms
9246ed4 275.63 ms 321.31 ms 45.69 ms
496bdfd 301.22 ms 343.96 ms 42.73 ms
8820c5c 330.60 ms 416.86 ms 86.26 ms
9246ed4 281.79 ms 352.08 ms 70.29 ms

App size

Revision Plain With Sentry Diff
496bdfd 1.72 MiB 2.28 MiB 571.82 KiB
9246ed4 1.72 MiB 2.28 MiB 572.22 KiB
496bdfd 1.72 MiB 2.28 MiB 571.82 KiB
8820c5c 1.72 MiB 2.28 MiB 571.82 KiB
9246ed4 1.72 MiB 2.28 MiB 572.22 KiB

Previous results on branch: rz/feat/track-manifest-usage

Startup times

Revision Plain With Sentry Diff
faa7323 288.86 ms 379.54 ms 90.68 ms

App size

Revision Plain With Sentry Diff
faa7323 1.72 MiB 2.28 MiB 573.45 KiB

@codecov
Copy link

codecov bot commented Jun 22, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (8de3797) 81.15% compared to head (b3e23b1) 81.15%.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #2795   +/-   ##
=========================================
  Coverage     81.15%   81.15%           
  Complexity     4501     4501           
=========================================
  Files           348      348           
  Lines         16685    16685           
  Branches       2268     2268           
=========================================
  Hits          13540    13540           
  Misses         2198     2198           
  Partials        947      947           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@romtsn romtsn merged commit 0310da5 into main Jun 22, 2023
@romtsn romtsn deleted the rz/feat/track-manifest-usage branch June 22, 2023 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants