Skip to content

Commit

Permalink
Support spans that are split into multiple batches (#3539)
Browse files Browse the repository at this point in the history
* Support spans across batches

* changelog
  • Loading branch information
adinauer authored Jul 2, 2024
1 parent c7232fe commit a62056e
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 1 deletion.
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@

### Fixes

- Support spans that are split into multiple batches ([#3539](https://github.com/getsentry/sentry-java/pull/3539))
- When spans belonging to a single transaction were split into multiple batches for SpanExporter, we did not add all spans because the isSpanTooOld check wasn't inverted.
- Parse and use `send-default-pii` and `max-request-body-size` from `sentry.properties` ([#3534](https://github.com/getsentry/sentry-java/pull/3534))

## 8.0.0-alpha.2
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,8 @@ public CompletableResultCode export(Collection<SpanData> spans) {
final @NotNull SentryInstantDate now = new SentryInstantDate();

final @NotNull List<SpanData> nonExpired =
remaining.stream().filter((span) -> isSpanTooOld(span, now)).collect(Collectors.toList());
remaining.stream().filter((span) -> !isSpanTooOld(span, now)).collect(Collectors.toList());

this.finishedSpans.addAll(nonExpired);

// TODO
Expand Down

0 comments on commit a62056e

Please sign in to comment.