fix(stacktrace): support package name parsing for Go 1.20+ #730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Go 1.20+ changed reserved prefixes for compiler-generated symbols from "go." and "type." to "go:" and "type:" respectively. See: golang/go@0f8dffd This adds support for both kinds of compiler-generated symbols depending on the Go version by taking advantage of build tags.
Codecov ReportAll modified lines are covered by tests ✅
📢 Thoughts on this report? Let us know!. |
|
Thanks! Appreciate you picking that up for me. I'll close mine out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Go 1.20+ changed reserved prefixes for compiler-generated symbols from "go." and "type." to "go:" and "type:" respectively.
See: golang/go@0f8dffd
This adds support for both kinds of compiler-generated symbols depending on the Go version by taking advantage of build tags.
Fixes #180
Inspired by and continued on from: #707