Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Only set ip.address: '{{auto}}' when sendDefaultPii: true #1079

Merged
merged 2 commits into from
Feb 14, 2025
Merged

fix: Only set ip.address: '{{auto}}' when sendDefaultPii: true #1079

merged 2 commits into from
Feb 14, 2025

Conversation

timfish
Copy link
Collaborator

@timfish timfish commented Feb 13, 2025 •
edited
Loading

This PR:

  • Ensures that we only add the ip address if sendDefaultPii: true
  • Adds a test to ensure the IP address is not added by default

@timfish timfish mentioned this pull request Feb 13, 2025
Open
10 tasks
@timfish timfish marked this pull request as ready for review February 13, 2025 12:21
@timfish timfish enabled auto-merge (squash) February 14, 2025 10:35
@timfish timfish merged commit 9175622 into master Feb 14, 2025
34 checks passed
@timfish timfish deleted the fix/ip-only-when-sendDefaultPii branch February 14, 2025 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lforst lforst lforst approved these changes

@Lms24 Lms24 Awaiting requested review from Lms24

@s1gr1d s1gr1d Awaiting requested review from s1gr1d

@andreiborza andreiborza Awaiting requested review from andreiborza

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@timfish @lforst