-
-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added SubstringOrPatternMatcher #3566
Conversation
…entry-dotnet into substring-or-pattern-matcher
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't have anything on the samples using this?
It would be used indirectly via various properties on the It's also used in the
But nothing showing how people can define their own string or regex to assign to any of those options. |
Resolves #3560
Summary
Previously we had a
SubstringOrRegexPattern
class that could store either a string or a regular expression and contained some logic to test either whether that string was a substring or whether the regular expression matched against some other target string.Instead we now have a
StringOrRegex
class that takes care of holding the string or regular expression, the ability to bind those values to configuration storage and provides various extensions.The logic to test that string or regex against a target has been refactored into a
SubstringOrPatternMatcher
class implementingIStringOrRegexMatcher
.